[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v6 02/31] build: introduce cpp_flags macro


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 7 Jul 2021 16:18:18 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tiZd7ZFXOjWS8wcBhYOz5OyozrZLS7mhkzr92yVjytM=; b=kXRpiAmunwpeklu1ZnH2dKVqCdM2APU0rnQcJV5MnC5mWZJuNzI/t8rSxbVwIerlq7L4N08lvlX4jtLTLGaF+k7xf9sruG2KAmf7Md965qZufx57xaATHy0EPKPcIeOApfGfsjyU4YSfZSmUnsuTmvH05hyb3pRCT0uJuWRoXsbkNUTMOXgq+tDqthZobM/ImKueh1sojs4hUKG7EipH41JcpERobVgTBUKWo8O81LZqLZfNLmgtNCCotwlf/dDJhyu0FMx/5EwY96+LJFH9HvjV4uiSOdncAC6vfIW38Th+gCPWw1Vd0qH1X5c6KZ5JeBjkGvLv8/Pz/Bwa0OvUag==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EukFQoSyVV9/J0fYOt1Cvxy15RotMOTmBmLRszRZjiE5wmnh+VQHbLQB0JhSAM0ty7HSSCXwOXnRs+ZN/ToSWD07lBbHSkYi+QGvHgn58M/OpRmOpUZ6jRIBZdGRZvT7fz9zxBm9yLx6Ua2hZLYzcVRkA1Oej69zmcR2CEA1Z6qjIHRKoZNCYPrZy/Md7dfoX6ETcfibMe0dOMbAEI1X5F5NZjuMFTAnrIXkKyHvDK/VOlr82I8N1FnU1snDG2Vs+M52dweSsxPW2FF/YfAQakK2hdxYyKMRpW/IDnM8iwEWufcCYDQdY24EcJQBgXrMPKZG/wLua44QJi0Ab/xgaQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 07 Jul 2021 14:18:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.07.2021 16:09, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
> 
> Notes:
>     v6:
>     - switch to a macro as suggested
>       which allows to be used with both a_flags and c_flags
>     
>     v5:
>     - new patch
> 
>  xen/Rules.mk                    | 7 +++++--
>  xen/arch/x86/mm/Makefile        | 2 +-
>  xen/arch/x86/mm/hap/Makefile    | 2 +-
>  xen/arch/x86/mm/shadow/Makefile | 2 +-
>  4 files changed, 8 insertions(+), 5 deletions(-)

There are two further uses, one in xen/Makefile and one in
xen/x86/Makefile. I think both want replacing too, and the
former suggests you also want to strip -flto alongside -Wa,%.
I can accept the use in xen/include/Makefile not getting
touched, as it also removes an -include option at the same
time.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.