[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 07/31] build,include: rework compat-build-source.py
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Jul 2021 16:58:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w/dvHCIjx78q5kgwP6+xD1Jn43uap/PQanehUWu6ESg=; b=bIOPvSAaWULyIeDnYLNXM/nR73coAaLnbGrZCVbxzTOo1hJIbeBbHGzVgWl8arj+YzEx8ey0Hv9ir4fd3WRwzZRIa5mwpqAUCVeIv4jEGqaFVqTYZj/rUaqQiv4RDg2qh7SIloj/X/YC1dNyA3uDUTSQtwSciiG4sU9+aQbyXrPdznnCvrL8pif+5KHU/FC4oKgu5WNS4WknxX8aZOnUy4EdqL/l1aiGr+/35eudYh+a8PLcD9b6F18Jzb5M6W1XkMkPq96mJBBcR5KO7hkqRGDdRzUtFwvvWNbh2gxQPVeHrcyKOApc3jyWU/1dyiRoYFMrIBFKaDNed1JwqV2SIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ELq2MNlwECO+NTrv8nfnl01AadH4r5YqIZZHPjfNMjTzJ5TQAVAFYhnYNhoO0dER9ecD3NmNvhJO5qsg/klV+9EFg58y28KixxgiJulKj7UlY7/PYJeHHcebSpfZ8HeiJUtXFFOm1QoUi2mYc5/DlKVNi1GVlPZJXA0Q6BfLVYdBsaBOx1BcESzo82IJgl/4+DKNQdgjW12tv2NSy6gKIZq9Z03iUS845AJLs9D/2LxI8SYSKq4HPMggtVwGZpyqKsDYrNEONhbVCgguLObexEnQ56ul5dxuo++eTZLUtQDWpUXEy6ZuKvWLbu4V0FTEGmiP156N1cpAJmyTiuM4KA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jul 2021 14:58:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.07.2021 16:09, Anthony PERARD wrote:
> Improvement are:
> - give the path to xlat.lst as argument
> - include `grep -v` in compat-build-source.py script, we don't need to
> write this in several scripted language.
>
> Also remove dependency on Makefile as the file generation doesn't
> depend on it anymore.
Did it before any more? In the subsequent patch I can see more of
a reason to drop the dependency, but neither there nor here I'm
really convinced: In general I think every generate file would
better depend on the makefile containing the rule used for its
building, as a change to that rule means the target wants
rebuilding. Therefore for the moment ...
> No changes in final compat/%.h headers.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
... this holds only with the dependency kept in place. But I'll
be happy to get convinced otherwise.
Jan
|
