[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v6 15/31] build: move make option changes check earlier

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 7 Jul 2021 17:40:02 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fNmVWWMwPJb34vqdlRm5vzD7Alq1jRH2uoPSe+Zvgso=; b=FJri5rYWm0Z5j2ZCtEThYJHKeDVQ6M4tvT9iCZOhIEPd1XPDJ9wgcxl+WpkEfIYvSawZfjZwqo1SZY2yxJjKDNtUZdcoFbpTzuIh+66JWzXVC/O2krPVMyXS/oYS4h92HEXX5JUpI4QCxc7ygUUuQYFBqRQHrRrByq+qT/5DevE7qbycZsKWP2VN7yCtafob+cd4fIC65uw1ZgoC7LP6dWojzM8BN7ahnCuqVMJ9izJq+hrh4nv8m1THBtaEvK6Bqn432zqGR9UqXdYdlcui6CmF5icfWJ7AOc8len8sKPWWex8l/rLlVVJIUJ2RlPWp70DnJU6xesFLMNSdZdaqxA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iyF9BxdbiF9NthNNXjptpYOBMIN/p/3jaHtvY0ATmBYK9xJb0rA/CJ1tzW/O/yC32XtW0L6TiPQApWRbXOcCOchZTYHtxWygKxB6nnhLfD2OhpGS56hLZlNEDdsD5aXP8UbsxlXg5lD8wjiNQHbmcXaL/n1yldd/aigDT74U/ZnCAfqWohhttoHRSTbmT8MGLAcs7X54SwH6qDQylWivtRI84UzAgI6doy8Z0K9lmbUEJR6j1DwOVTLrtQGpDiWbu4BEGEN2DYWHv0HV+I643+ixXxJGTMe1ZB7kziyq2tjPP2gaRipZHyJMoljVIxSgWUSi1/E0ajE3vospG97IUA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 07 Jul 2021 15:40:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.07.2021 16:09, Anthony PERARD wrote:
> And thus avoiding checking for those variable over and over again.
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
in its present shape since all you do is move existing logic. But I
wonder if I could talk you into ...

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -56,6 +56,28 @@ include scripts/Kbuild.include
>  ifneq ($(root-make-done),y)
>  # section to run before calling Rules.mk, but only once.
> +ifneq ($(origin crash_debug),undefined)
> +$(error "You must use 'make menuconfig' to enable/disable crash_debug now.")
> +endif
> +ifeq ($(origin debug),command line)
> +$(warning "You must use 'make menuconfig' to enable/disable debug now.")
> +endif
> +ifneq ($(origin frame_pointer),undefined)
> +$(error "You must use 'make menuconfig' to enable/disable frame_pointer 
> now.")
> +endif
> +ifneq ($(origin kexec),undefined)
> +$(error "You must use 'make menuconfig' to enable/disable kexec now.")
> +endif
> +ifneq ($(origin lock_profile),undefined)
> +$(error "You must use 'make menuconfig' to enable/disable lock_profile now.")
> +endif
> +ifneq ($(origin perfc),undefined)
> +$(error "You must use 'make menuconfig' to enable/disable perfc now.")
> +endif
> +ifneq ($(origin verbose),undefined)
> +$(error "You must use 'make menuconfig' to enable/disable verbose now.")
> +endif

... doing away with the misleading mentioning of just "menuconfig" here.
There are various other *config targets, many of which are also suitable
for the purpose. Personally I've used menuconfig (in Linux) the last
time perhaps 15 years ago, and hence I have almost forgotten about its
existence. IOW at the very least I'd see us insert "e.g." everywhere.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.