[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 17/31] build: convert binfile use to if_changed
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Jul 2021 17:48:57 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+0Z9u/K7f3vtGeuW0Z3V4KYztYfbieEU3MfisQUwMFs=; b=dCtDFibsJZEz0YdJOcyn2VLbvU94x2CMgMn8Ipy3qiFmmQMXtKiaZpv1RkVMJBsqxwzrWRNtGoD4K6ZxljOpV83lsBje9dmCRMSt6RdurlAr3cdtlj4Yowx6FlN0lgYUkmNNY4AfK82MJiXCwMFTAXzo8spz7/03BO3xNfJiMDCuMTHdeTXQO0F/xPEEuB7ORdfl3OOsuxPwdCP6WOUGKDKJHL3RMXkwsESiYuvLvzw/L02Si68AGiG/XP7rI9/bWy/TU10P/efI3JY2+6HaP16vSpEnWRl5n2fGCIBHUPRrnMUC3JYGSqv2CqRcaCI8YODInCQBy0l+3JhOTE/aNw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c7KfWnCDyEtfjZeBb67zrVUZnH65HcEfAkt+EAUuEXSRNrFY9C4cEM/sapMq4y35pevssT6/Of8a9BQuLtAA2zDysYnURKSPfufsADFOC9tPPspQiE8RLTh5OFWRqXhRtDBjx9XdWl3Oiv6A6nAEwCRlaIUQPMKtgVERFmghPips/unGYj1OXHeIrD5ky8zsEfhEBBUISDvgEy7001uZT23NtoUml+QCrDp/dwwtgt5/uwJE0nXz52Phcb/XwhQI02qWJFQilxEd3T+9MZ450lM/moEHjEWrPOYOmKQZ6PXEMJWAQKkLO3fM/kvzgBi7ukcwbT2U66yGU+iu+LUL3Q==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jul 2021 15:49:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.07.2021 16:09, Anthony PERARD wrote:
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -80,8 +80,12 @@ config.gz: $(CONF_FILE)
>
> config_data.o: config.gz
>
> -config_data.S: $(BASEDIR)/tools/binfile
> - $(SHELL) $(BASEDIR)/tools/binfile $@ config.gz xen_config_data
> +quiet_cmd_binfile = BINFILE $@
> +cmd_binfile = $(SHELL) $< $@ config.gz xen_config_data
This is an abuse of $< which I consider overly confusing:
$(BASEDIR)/tools/binfile is not the input file to the rule. Instead
the script generates an assembly file "out of thin air", with not
input files at all. The rule and ...
> +config_data.S: $(BASEDIR)/tools/binfile FORCE
... dependency shouldn't give a different impression. What would
be nice (without having checked how difficult this might be) would
be if quiet_cmd_binfile and cmd_binfile could move to xen/Rules.mk
and merely be used from here (and the other location, where the
same concern obviously applies).
Jan
|
