[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 8 Jul 2021 12:23:38 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jRJ8gXC6RBFPQjBvCkDOF4p2MtJZRtCX/AjIffnMPMw=; b=dThEguynpz8XO1Q1elIyJaoCpVBBhjoKncdVjcChUU5AMpjSjRORbbUTkQwFmZdyIkpzuk3FwibEk/AS4EKmWPjEWj/wWlCNHrSQQtN5nQpKD405iPwxz2+7ydnK9oZoOkt9KTGb9USECP9NrjBljB021COZ6r/qsrxcJudtFrW55pCfl50fo9CgZw6H6BBw5aO1pW1tKiLJvPDghj/nRdx8wAyM2XmGxFLHxRNXE1X4vZVal7WIrMFq1AOdK2g/kQcg93y9HuN8Jhb+9r+vz66hvLQLAemhCm6jETqWjmf3HFGL/JFD/ucmMaAIv+73JEcYAgDoTEn8HSDJfQODXw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GHV/V9gtsCoUrLbgIj0LDYw8umOwoaX+5/+qlMMvKqJPjFbq6NwXbsGk8mWMjPDSBalX8wzBeNpKdOjhTemEya5iSHa76eirvysT5s+cBm4T0pVG/PbQ1HM9AVusc+1JAvMsE6+3TIL+n2ey8B3duIm6Djz2XWvs2QHu44hIvdPJdq+BskzW7q10LDP4wkfSx1BxKKsfaQIr+/g+7eDW9Py6lHFDG0VVvyziejzqmGIvvaZ0IHPGKZwE/d0wxHe73oCE78eumDS8jb09RREhaELVsk4ffV4doTf0U8LheaRPAQt3v/vEzZHTaGNJGnoicclXctDNQbpCzBCgKIREng==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>
  • Delivery-date: Thu, 08 Jul 2021 11:24:01 +0000
  • Ironport-hdrordr: A9a23:6qWhXqypPopB77zI1XYBKrPxwuskLtp133Aq2lEZdPULSKKlfp GV88jziyWZtN9wYhEdcdDpAtjlfZquz+8K3WB3B8bcYOCGghrVEGgG1+rfKlLbalbDH4JmpM Fdmu1FeaDN5DtB/LXHCWuDYq4dKbC8mcjC74qurAYOPHRXguNbnmBE426gYz1LrWJ9dOME/f Snl696TnabCA4qhpPRPAh1YwGPnayFqLvWJTo9QzI34giHij2lrJb8Dhijxx8bFxdC260r/2 TpmxHwovzLiYD79jbsk0voq7hGktrozdVOQOSKl8guMz3pziKlfp5oVbGutC085Muv9FEput /RpApIBbU811rhOkWO5Tf90Qjp1zgjr1X4z0WDvHflqcvlABonFston+tiA1nkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooEAljfUYgxVkIMgjgYdq3MgiFX5uYdA99HqQ0vFgLA AuNrCd2B9uSyLeU5iD1VMfmeBFNx8Ib2W7qktrgL3e79EZpgEg86O0rPZv10voz6hNPKWs0d 60eZiApIs+OvP+UpgNctvpYfHHR1AlEii8fF57HzzcZek60jT22sXK3Ik=
  • Ironport-sdr: RVpuTz0ktAPhAFYUvhq1Hu6jJQEySuDlKRGUm83lF7+szD/cgYrVFhrtLtmZMi6IVpzm6Ad7Wz RxC4SrXZlE9wGo12a2U5T4cAVB9wM0qNDLeRSCIoelCUUabZ1o4/BySZIK7kV8a5A7GIUGgZcU lE6POiwL/Okp+oAFMGdjec398TGW7FXiPps42hvz2nvqkjNhuv+W7LpKdnWTa7vjsXAYTWYWs6 bGOIgNJDSVmCAom25grl9IXWGtp9dBMeipADCC3Fhau33I7vS87AYhMDSTst5KdBfAjatxDAlZ mtU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08/07/2021 11:52, Anthony PERARD wrote:
> On Wed, Jul 07, 2021 at 06:46:03PM +0100, Andrew Cooper wrote:
>> On 07/07/2021 17:40, Anthony PERARD wrote:
>>> ninja is now required to build the latest version of QEMU, some
>>> container still don't have ninja and attempting to add it breaks the
>>> build for different reasons, so QEMU will be skip on those containers.
>>> Failures:
>>> - ubuntu/xenial:
>>>     fatal: ninja version (1.5.1) incompatible with build file 
>>> ninja_required_version version (1.7.1).
>>> - debian/unstable-i386: (debian-unstable-32)
>>>     /build/tools/flask/policy/Makefile.common:115: *** target pattern 
>>> contains no '%'.  Stop.
>>> - suse/opensuse-tumbleweed:
>>>     failed to build iPXE
>>> - debian/unstable:
>>>     update of the container fails with:
>>>         The following packages have unmet dependencies:
>>>          clang-8 : Depends: libstdc++-8-dev but it is not installable
>>>                    Depends: libgcc-8-dev but it is not installable
>>>                    Depends: libobjc-8-dev but it is not installable
>>>                    Recommends: llvm-8-dev but it is not going to be 
>>> installed
>>>                    Recommends: libomp-8-dev but it is not going to be 
>>> installed
>> Only the first failure seems to be related to ninja.
>> The second is a known bug which still needs addressing.  Our build
>> system's logic to cope with `checkpolicy` being absent doesn't work.
>> Tumbleweed is generally broken and fails at ./configure due to missing
>> compression libraries.  It is quite possible that the iPXE failure is
>> related.
>> The final one is probably because unstable has dropped clang-8.  The
>> container hasn't been rebuilt in a while because we still haven't got
>> auto-rebuild sorted.
> So those containers are ones that I've noticed needed ninja (as found
> out by looking at a single pipeline), but one which trying to install
> ninja and thus rebuilding the container mean that the build was broken.
> I just didn't want to spend time trying to fix issues that should have
> been found out by a regular rebuild of the containers.

That's fine, but as these containers weren't rebuilt, the details of any
knock-on error aren't relevant here.

I'd go with simply:

"ninja is now required to build the latest version of QEMU, and not all
distros have a suitable version.  Skip the QEMU build when ninja is not

Can fix on commit if you're happy with this.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.