[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 08/10] xsm-silo: convert silo over to domain roles
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 8 Jul 2021 15:17:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wyfmdxiIyabVcikSXehTwfXS7Hk9myvO060s8bSdjMg=; b=gdbb+RLhvQmj61UNkSCqSbuaxwuDgVShJIOlLfBe0OOJ+k6J84UTXybyP8BYSzNV/qvzeexTxflbEmsMnzNt7bzP9YLpJXRor0u+DKWHhjL6H6IBlFeXUEfUYU0tAWD1TSJpuqMrnc1229+KcYz2DQ6r2BgmZ++UiKIRvUM0MI4IG9ZlhCXYbj8NpuHNF7e8sj+OEIjl+Y6i5fJvFepRI+yvuKZG96UzCwaknIxo6qjfzP9QPQAxENucgn+xKGPt7DwMiuMYsJzV6XY4pdeeeT5bgqIToruyeeM8J+nacMkz4ieJNBREx9ljEnQvd8P84NIzCSne0Z7WCaITREo0hQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mpfwj2XHHV7hIFf0TVC+ZJM6vQAyL3H9vyhExdCoLJjFa1cj2fMnNn2iW0zl8QcqtrcHtwQNIUsDwSLVRDE2gZhU/PinuTtxWJqu62jiSHMD9DwJvQW2OFjqfw+LUMI63ePI4RXMe7X9hiIQvtX4iZXmdEWbwxfjpq4DVRW6WIlIJzlT1soHAmlxGzZFyd8MqygvH30DHfg+Y1F1xiB0E1xSe5IuB6L7AJSm3TjOiffbyC0hn2cPFXKryQr6EnZp4YE266F1cWC8tAb55OrTA/ACd5Wt23VCAo/0dNXY/sPZIAmo/PCtxwopuAV4+1t+jcmDP1KbWi2x6xSucLv/fg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, iwj@xxxxxxxxxxxxxx, wl@xxxxxxx, roger.pau@xxxxxxxxxx, tamas@xxxxxxxxxxxxx, tim@xxxxxxx, jgross@xxxxxxxx, aisaila@xxxxxxxxxxxxxxx, ppircalabu@xxxxxxxxxxxxxxx, dfaggioli@xxxxxxxx, paul@xxxxxxx, kevin.tian@xxxxxxxxx, dgdegra@xxxxxxxxxxxxx, adam.schwalm@xxxxxxxxxx, scott.davis@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 08 Jul 2021 13:17:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.05.2021 22:54, Daniel P. Smith wrote:
> --- a/xen/xsm/silo.c
> +++ b/xen/xsm/silo.c
> @@ -17,9 +17,11 @@
> * You should have received a copy of the GNU General Public License along
> with
> * this program; If not, see <http://www.gnu.org/licenses/>.
> */
> -#define XSM_NO_WRAPPERS
> -#include <xsm/dummy.h>
>
> +#include <xsm/xsm.h>
> +#include <xsm/roles.h>
> +
> +#define SILO_ALLOWED_ROLES ( XSM_DOM_SUPER | XSM_DEV_BACK )
Assuming XSM_DEV_BACK means (or at least may also mean) a backend outside
of Dom0 serving another domain's frontend, ...
> @@ -29,8 +31,10 @@ static bool silo_mode_dom_check(const struct domain *ldom,
> {
> const struct domain *currd = current->domain;
>
> - return (is_control_domain(currd) || is_control_domain(ldom) ||
> - is_control_domain(rdom) || ldom == rdom);
> + return ( currd->xsm_roles & SILO_ALLOWED_ROLES ||
> + ldom->xsm_roles & SILO_ALLOWED_ROLES ||
> + rdom->xsm_roles & SILO_ALLOWED_ROLES ||
> + ldom == rdom );
... I don't think this is an appropriate conversion. Aiui a backend in
a driver domain is out of reach for a domain in SILO mode.
Jan
|
