[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 13 Jul 2021 16:28:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DznpkMNqZ0ohejiR3qL3nZcQ+XKnW2f7V7/asPvb7o4=; b=YW6nQaBcG6GWMXCx3R9J3h0lykYv+6RFNXw/q/0p4OYsnB/uHaVVf/gD5uzjIP8VLFhwOGyXpZAKSCwH/zYw2YS92Q3s48zAsM6gwi+O5PbhqXbi/AVdzPiJodICCnkovML1Kd7OUxP9PpaHA9B0aLCxsNdLO76TsBoJjh3I7j8n7ZGdhJagMf7cY+3b5P6340X8fty60eMDmcO0ICQZ5BT1hZAGpMOgunVThxSLsDrawSrxYfaKVkSSlsB5LpnWHmD74bok4mrXRDw99WjqvuQsaYk64sU2ALvZqyNxinUNdzGJlJRYSXMgVyFWgTvW2cE4xCpgaAXBQpikoWDcQQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gKFOYHhtFd2sYMyppvV+mdeqO30ramvHc6fdAIQYW85WshGy3N9GmWeDWFuPvvcav7GD79Rmt5+VMmrW/tvYNKN+i7ArfiKaetM0P2tHIryO4JYrEVQyaiEZ+PktMWqphLsVO/hLfa/e0yPqS3URB/a39TyKE1tSHOlRawoygtAMFov7dDiwy3mtH0GMEMm/CDryVpuRoA4PsgrATOZmewPS5aaudOm2iAtT+eGY05iOgbf2O6QOVOjpAgZouJ1wTFWkOAo7bNQP+BXVDN9yqngNP0FN0WYnwkLVZNJW/VWFO5jGw2H4WPUOjp6J3ABL/lMb7jSko9crzGfhzZvwWw==
- Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Costin Lupu <costin.lupu@xxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Tue, 13 Jul 2021 14:28:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.07.2021 16:23, Juergen Gross wrote:
> On 13.07.21 16:19, Julien Grall wrote:
>> On 13/07/2021 15:14, Jan Beulich wrote:
>>>> And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*.
>>>
>>> Even that doesn't seem right to me, at least in principle. There
>>> shouldn't
>>> be a build time setting when it may vary at runtime. IOW on Arm I think a
>>> runtime query to the hypervisor would be needed instead.
>>
>> Yes, we want to be able to use the same userspace/OS without rebuilding
>> to a specific hypervisor page size.
>
> This define is used for accessing data of other domains. See the define
> for XEN_PAGE_SIZE in xen/include/public/io/ring.h
>
> So it should be a constant (minimal) page size for all hypervisors and
> guests of an architecture.
But that's only because of limitations baked into ring.h. For example,
a grant shouldn't be (address,attributes), but (address,order,attributes).
A frontend running in an OS with 16k page size could then still announce
a single ring "page", and a backend running in an OS with 4k page size
would still have no trouble mapping that ring. (The other way around
would of course get more interesting.)
Jan
|
