[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

On 16.07.21 17:26, George Dunlap wrote:

On Jul 14, 2021, at 5:17 PM, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:

This will help prevent the CI loop from having build failures when
`checkpolicy` isn't available, when doing "randconfig" jobs.

Hang on, just to clarify what’s going on here.

‘randconfig’ is setting CONFIG_XSM_FLASK_POLICY in the .config file; and then when the 
build happens, we error out because one of the required components isn’t there.

What this patch does is to make it so that if someone explicitly sets 
CONFIG_XSM_FLASK_POLICY=y, but doesn’t have checkpolicy, the build system will 
silently disable the policy behind their backs without telling them?

Or does the randconfig test run kConfig one more time, at which point *then* 
the .config will be disabled?

The former I think is broken; the latter I think is fine.

I still think that Kconfig should not disable explicit settings due to
tools not being available.

I'd be fine with trimodal settings for such parameters:

- Off
- On
- On if tools available

And the last one could even be the default.

But anyone wanting to test a specific option or to enable an option
should not be catched by surprise because some internal modification is
requesting another tool which happens not to be available.

BTW, the same applies to ./configure options for tools. I really don't
like that some components are silently not built because e.g. a header
file is not available. I'd rather have the possibility to tell
./configure that I want everything built and let the build fail if that
is not possible.


Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.