[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

  • To: Julien Grall <julien@xxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Scott Davis <scott.davis@xxxxxxxxxx>
  • Date: Wed, 21 Jul 2021 22:30:24 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=starlab.io; dmarc=pass action=none header.from=starlab.io; dkim=pass header.d=starlab.io; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NNOLrlnNGUcqK4MGZRZFcF7QTzCrlvG8mVdIQd2HIYw=; b=Mco6XDkxJG9Yb5xgmksLk5WfnAc5tzi+tOTD84BxmosGzdmWj4DVDz1iDPRJNRQ+yWRmKrbm5Ns7YK94eLJtcu2pchxyqbZbrefJ8Qvcwse//fQqiQTSZH43NCHFj4z+Fw8Kue37Bbbqv8Q412EAe+6GIAg/XiBCvFpp1Nx9AWKM2kCXtHM7u9e9Od9N8AotAjzBDPMurMfSvkWm4VWuTnk/DpeZtzAyXtcWpgeyJ2I+ewC53rcGynPMgE+ZowP8MIvhTf+4GCHcHQ3TnNPO5P9zVaFHRxn6DPtvmOkkJdo61Yz0lLQnEFJBpaCdPojvhGvKf1t1WgHRF7JPE1uqNA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/XmaAM1JS1O2TG/3yATnk7FEtRjtXj1bqhlikAlFNzzWAsVeCIvMgjWxeciIJRbq8P8kNE6UhQcjLyGywQ3bAa9NPHHGjHTohyA8gfbigptYceYjT3Y71v1dooT4yHH4VD5K4XA4DavcEXPrXoNyOttp0ZltZMhmwn5f2s7GjFOd6wHKGnVphJulnK6BnuvT8eFhpiVf3waWW6VmFoALIajJ5qjurY4qekkdjWmtZhsqj6OS9Ny2kS6EkDhl7k5NPQF0ivzMEZ7V1rzkaPi1KXF2iCrAtesnf/WMYrLSEZ86tWTbr/MHdfsfiC1Q0pU3Tka22vGC1gk5wLkLVF05w==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=starlab.io;
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Wed, 21 Jul 2021 22:30:48 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXfZDNgVrtHzLC8keYeUzq7QcR26tNF7mAgACqFQA=
  • Thread-topic: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

Thanks for the feedback, all.

On 7/21/21, 4:21 AM, Julien Grall wrote:
> May I ask why embedding the command line in the kernel would not be a
> solution? Do you expect it to change from stubdom to stubdom?

Of course. For Crucible, we're using a common kernel and initramfs for 
stubdomains and driver domains. The command line lets us tell each domain 
type how to configure itself on boot via the tool stack.

> Please add a LIBXL_HAVE_... in include/libxl.h. This is used by external
> toolstack (e.g. libvirt) to know whether a given version of libxl
> provide the field.

Ack. It appears there was not an entry added there for the other 
Linux-based "stubdomain_*" fields when they were inserted last year, so I 
will add a single entry in v2 to cover those three (memkb, kernel, and 
ramdisk) plus cmdline, unless there is an objection.

On 7/21/21, 8:42 AM, Jason Andryuk wrote:
> I think this option actually sets the string, so you want "Set
> B<STRING> as the device-model stubdomain kernel command line." or
> something equivalent?

Ack. As you later noted, I copied the "Append" wording from the cmdline 
option on the assumption that xl was leaving room for itself to add other 
items to the command line in the future. Will use "Set" in v2 for clarity, 

Good day,

-Scott Davis 



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.