[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH v2] tools/xl: Add stubdomain_cmdline option to xl.cfg
On Thu, Jul 22, 2021 at 12:54:30PM -0400, Scott Davis wrote: > This adds an option to the xl domain configuration file syntax for specifying > a kernel command line for device-model stubdomains. It is intended for use > with > Linux-based stubdomains. > > Signed-off-by: Scott Davis <scott.davis@xxxxxxxxxx> > Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx> > --- > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index ae7fe27c1f..b9ba16d698 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -1030,6 +1030,18 @@ typedef struct libxl__ctx libxl_ctx; > */ > #define LIBXL_HAVE_BUILDINFO_KERNEL 1 > > +/* > + * LIBXL_HAVE_BUILDINFO_DEVICE_MODEL_STUBDOMAIN > + * > + * If this is defined, then the libxl_domain_build_info structure will > contain > + * the following fields that specify options for device model stubdomains: > + * - stubdomain_memkb: integer indicating stubdomain RAM size > + * - stubdomain_kernel: string indicating stubdomain kernel image location > + * - stubdomain_cmdline: string of parameters to pass to the stubdomain > kernel > + * - stubdomain_ramdisk: string indicating stubdomain ramdisk location > + */ > +#define LIBXL_HAVE_BUILDINFO_DEVICE_MODEL_STUBDOMAIN 1 Looks like a LIBXL_HAVE_ macro was missing in the original addition of all other stubdomain_*, so it's probably fine to add a macro now for all of them: Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> > diff --git a/tools/libs/light/libxl_types.idl > b/tools/libs/light/libxl_types.idl > index f45adddab0..e782e15cf2 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -523,6 +523,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > ("device_model_stubdomain", libxl_defbool), > ("stubdomain_memkb", MemKB), > ("stubdomain_kernel", string), > + ("stubdomain_cmdline", string), > ("stubdomain_ramdisk", string), Thanks, -- Anthony PERARD
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |