[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: work around build issue with GNU ld 2.37
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 27 Jul 2021 13:33:43 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s+v8daMtcYCJNQvFoXvV/YLBWeaOEW2XizQZEI/L3sE=; b=mFtHgXBTYX9Wp2C13KqeRegz/ZNDmRuHfF0IHdkk0uZiYhG/WS4SyfJ9APIu82MOAeWU+ORULtZhdBTh2955QDINZwWYyzO0xWwQOrcWH12cD0CNwslymU/dZ5iAE/Gbd2vdvaB7jN868l08thec8/xaw41BNfPpnjEhjzAiqHN7ytQajE2HnCOWta8XYu9qtFC9b1FgCouKFgyEEUeiGhl0/Dzm///SQBfgdpbKXKLb9zfJiCTwKYp7QPp/HT8MFXn4PNzCk/5KqvmRbo+JuhwQOB9imtx53DrtiUdza8ShR3AKrbvnBnoQRHtj1x/hJVgHuSXXSke8XIDMQyJi4w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dWTCs2xVRRs/4fq6XrR7k6SsWfHPs2EqZYItkBSoYvcR4k7SFp7g8kSppBR9Tgq8CHiYa0c5d8qFOsBje+WYn+rWs62MacnS1L962crHY+/In1/534nvljPi4gCswq3+58lLLaVyrD4py/N5W3nWMK2vaiIWwaUXI+fVHlk6RMLoJ1JyWCNH1gXizzE4Us/kvJgRZf5IizvVCbjLEcR++2Q2vONSpNBUSHkcWdrGJ5/Sl0ipH+QE6NCy5DkH6ksgN9NSThCpaNDEvHMJPOgffvu+SD0DW90357x4fIBnk9R8avEDT7yiLqHgmaw2GXYwujYzBPFAaJSjYSUf0TR3Kw==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 27 Jul 2021 12:34:08 +0000
- Ironport-hdrordr: A9a23:9oJWxKp/f5KAttw//t3KE0QaV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V
- Ironport-sdr: XKTbVGTCqsThzkdnFQH2VzmuBMFuvt6mdAaYggEQZ4Q1/oWrDBDJXtb8UleZLgQITtX6r1k3tY KqNFBB/YxafELaoibjwwd9uUxAn8Y6K8aVV0h4oGJZgqU2eRpfvqQPFEdmIdi48B2eVzTM/8Y3 py6VqN+Kj4UpBcv+NuJnCbqjKWN48ycuuDaOnGfUo9A1Z9b/SOny7tyPXPJXpN+QnwpVvK+Rvu X64F8E5Pfip7AqcB1vI0y0wB5ycq2S1BjsXamUzM9CS+QjImgp/VgHIthg0NeJhOKp/scv3pcX 8sOk6DE4LSeVYozmQbCvEmIA
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/07/2021 10:20, Jan Beulich wrote:
> I suspect it is commit 40726f16a8d7 ("ld script expression parsing")
> which broke the hypervisor build, by no longer accepting section names
> with a dash in them inside ADDR() (and perhaps other script directives
> expecting just a section name, not an expression): .note.gnu.build-id
> is such a section.
Are binutils going to fix their testing to reduce the number of serious
regressions they're releasing?
>
> Quoting all section names passed to ADDR() via DECL_SECTION() works
> around the regression.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
I guess we've got no choice. Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
>
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -18,7 +18,7 @@ ENTRY(efi_start)
> #else /* !EFI */
>
> #define FORMAT "elf64-x86-64"
> -#define DECL_SECTION(x) x : AT(ADDR(x) - __XEN_VIRT_START)
> +#define DECL_SECTION(x) x : AT(ADDR(#x) - __XEN_VIRT_START)
>
> ENTRY(start_pa)
>
>
|
