[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] VT-d: Tylersburg errata apply to further steppings


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 3 Aug 2021 15:06:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SKAexD0jpo8G3aRTo44bCMwjJ/b5JQlrrEcQKrf1jt8=; b=Z7raWC8SAK/ks5K8DRiUiEEZ/BBVzVAddxe6PeyBQ4QXWt40Fr8vfIYGvtGuvWZGaut9S5jfnPClGqBkq6XBh3p7wu8Yf1D/CHHBV6QtLrQWoKmhPTPolXhT/XA2YiVb05zoq6rkQul3/Gt2FzenC1FPBmTVsWEbGF51wUecJ0kIDX678yTDtfinjGWGY3CqPCF5s38TPEQo049g0I93fUW4ztbAcYZEOrcrFMXCBSxNJ8bS31A9Cd/WGQCFy1NOiVfZR2gzadc0OGAEv4bWdEj4gR/d2uPLkrtVY1gwB42mt7Dm2sbmgs/jZFzivM0bANnstAX55DA+19JviGm6nw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cMdrB5n5tmER2gUJnIERgE4rkD2PXYzhJ8O+T6smVXdZsqVseoTSDB5Yy9pc1hxCElatHq9U+aQvd/o/FFjOPuKCR1yKtShRzLDv2UVgWXuDOrpDmguy25eU87A5QMowmWxq9swsDzcxy9i/3sgtxKPkESQh8O5IQj5IcY1hdBRQHz+Y26fYnKtlsnVp1R+cfBz1UJNWG4J5Pfkqa12txXacYMCQ73mqi/1MYpWLE6oPyBg2mAgA6LqL2pi+MmkjLLtV/qAi4uss5DNAEfuATg/ukiwbP3dgXPI2OuaZkIFgt5f74EQeIgsUWwQvYk7crLujxdfryDSLI2EbFwrqew==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 03 Aug 2021 13:07:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.08.2021 15:01, Marek Marczykowski-Górecki wrote:
> On Tue, Aug 03, 2021 at 02:29:01PM +0200, Jan Beulich wrote:
>> On 03.08.2021 14:21, Marek Marczykowski-Górecki wrote:
>>> If we would have an option (in
>>> toolstack, or Xen) to force interrupt remapping, then indeed when it's
>>> broken, PCI passthrough should be refused (or maybe even system should
>>> refuse to boot if we'd have something like iommu=intremap=require). But
>>> none of those actually exists.
>>
>> "iommu=force" actually does prevent boot from completing when
>> interrupt remapping is available, but then gets turned off for
>> some reason. See iommu_setup()'s
>>
>>     bool_t force_intremap = force_iommu && iommu_intremap;
> 
> Ok, then, just setting iommu_intremap=false should do the right thing,

... if "iommu=force" is in use (but not otherwise), ...

> if platform_quirks_init() is called somewhere between the above line,
> and actual enforcement of iommu=force few lines later. I couldn't
> quickly find if that is the case - is it?

iommu_setup()
-> iommu_hardware_setup()
-> iommu_init_ops->setup() (i.e. vtd_setup())
-> platform_quirks_init()

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.