[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V4 07/10] xen: re-define assign_pages and introduce assign_page


  • To: Penny Zheng <penny.zheng@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 5 Aug 2021 08:34:39 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CWp4TOWuChhi3rqDzRsggi/z2q8u6ldXTLLYCrL488M=; b=B9Sp5iHK8TTq8FF6oAcr1zysAaHgPbJ11Qfla5czAn04GunBD14XiQm7vvDvfoPfC6bO+PcXSw9n9w3fcz0WuMTqXrkO3yl3WuBVkiLFCGrg5KajwzdifTMW5aArAOdObrUNRuPKMmgKpl6zjCyahCQRPl3Hr7El3lNVYlNY0bh0jmOmYXq4YOqcSZT2kZmOYPl74e5e7tDqirFuh1kg+RVr163cFhEjl2JXwDMXw4isMS4ga1v8vQamNNApYs7/sB1ccv9pEJ+vkZTwc8BvybkuuRPbZvo9hQb79z8VAfEOTGDVTC1vvfyahDnmPLijUpvm1jABJ1yO2DsaM0HLgw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XU7VePp31ozwZfwvBDRKr9qae96yHxTck9g1Mm1psvXIH5n90UFBHS7VdSnme0Zcs0l3N5HZNB0YTyxbgH23RVDNbI/P08JVwrEftjaLbQYi4nledMP6puPX2Dla5ScAulMlh5O89kfgkW4KOTr2oAZG7QdBUBmQ4lAxbSpOJERLoYwqGfun3wejIYbAMGVmyxuRvMoT50hWbGItDRZwePBezsjPcQXK1WDDGW/Rk9K80tj/xSQWLABapcyA31aH/9qqmgUAid1sdTLVCYHmmVmitEJbKo3ey9lEp2ART0Hu0szMADkIl6KpbHoTUFAzJxW/p0IfEYUqkF+7fqqOOw==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand.Marquis@xxxxxxx, Wei.Chen@xxxxxxx, nd@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, julien@xxxxxxx
  • Delivery-date: Thu, 05 Aug 2021 06:34:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28.07.2021 12:27, Penny Zheng wrote:
> In order to deal with the trouble of count-to-order conversion when page 
> number
> is not in a power-of-two, this commit re-define assign_pages for nr pages and
> assign_page for original page with a single order.
> 
> Backporting confusion could be helped by altering the order of assign_page
> parameters, such that the compiler would point out that adjustments at call
> sites are needed.
> 
> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>

Largely to indicate my main concerns were addressed, yet not so much to
indicate I'm actually happy with the introduction of the 2nd function:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.