[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 21/31] build: set XEN_BUILD_EFI earlier
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 5 Aug 2021 09:27:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzKWbWcn4o74WX1CefrhNZw6LYIzIxlSlEJygoPHE0U=; b=XOINSS0+r287PFxSFQpK2jn1v3cKxIBVKXyx0cqNV4LvFbAzHyTIsi0OmZzgnrMy1yPNW7tWjaXwKHz86AZys722nDsEw2Oymggwumeld00s4dOVMpQ74keY58ORwDmPcev4dH0c8b4vutiE1wCmXGrFUT0r40MerA7ia2gbrQIIyu2VtHtbQE5AVsrRXlzM5ZQWoBjf5HIRwIdhbVCrDtiXVQshF48XglVHvKp9rSoPMH2MxG3zVIaKbDGvHptSklEfuesTIkk8TlXPmhicvqdqfTskCwZfhTrXyDHyf5VIUES04zuVrGHdK4xYHK7XnfbaRDoR6uWnwcLX7DOhEQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jc9BLaca+yWj/mgB+XIn2gQ9brEcdir1OBnQwxPb0/egbYYUafu4Z3cmpd/lVNqpzVyDSrC5yyY3gj7OwliR+NCJYlDBqpXdquxBsGT4yEsWOBlDfyRkWhfoWuc3zfspU+pkEi0BCJmmCpRHipfGMU3MSk7g61KrUQP9CTmt6AdQKbVD8i5+J+4gspTA4vFm3qWgJHtop2Yl2l9cgswzPEmEtAVTIWSnmxVqyBCYEtZHZ3SoCc1caexdcceMlc4ZSR4+OovDx8nZDH7gAvmPXBQG3KtufPwGG8+sIlwiMaTQgRaeESMa4yf4RYSxojQ+TBtprlQgEyCSFoFOgkMiWA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 05 Aug 2021 07:27:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.07.2021 16:10, Anthony PERARD wrote:
> We are going to need the variable XEN_BUILD_EFI earlier.
>
> This early check is using "try-run" to allow to have a temporary
> output file in case it is needed for $(CC) to build the *.c file.
>
> The "efi/check.o" file is still needed in "arch/x86/Makefile" so the
> check is currently duplicated.
Why is this? Can't you ...
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -126,7 +126,7 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
> ifneq ($(efi-y),)
>
> # Check if the compiler supports the MS ABI.
> -export XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o
> efi/check.o 2>/dev/null && echo y)
> +XEN_BUILD_EFI := $(shell $(CC) $(XEN_CFLAGS) -c efi/check.c -o efi/check.o
> 2>/dev/null && echo y)
> CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI
... use here what you ...
> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -60,5 +60,10 @@ ifeq ($(CONFIG_UBSAN),y)
> $(call cc-option-add,CFLAGS_UBSAN,CC,-fno-sanitize=alignment)
> endif
>
> +ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y)
> +# Check if the compiler supports the MS ABI.
> +export XEN_BUILD_EFI := $(call try-run,$(CC) $(CFLAGS) -c
> arch/x86/efi/check.c -o "$$TMPO",y)
> +endif
... export here?
Jan
|
