[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 25/31] build: remove unneeded deps of x86_emulate.o
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 6 Aug 2021 18:06:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cYDCbMR++wtd//yhkKdkkFpEBbqgQFcxk9SRvWjLtfI=; b=QQYmSJjIvMiu3hAg3Igmr243lXb1NlR36IJ4oYkdcYCt6FCxYaWOypSxSGtXDblsxEd3RVlhew7orkM0LaJbUhESuGrMHUjP0on/pGMH47h2sVyWnh9RA+oq/T6q7gDD72IJ+s+XhbulnOOcdhiFWwM9aB3+oV139j6cxj7J9HL9Ee37n8rCNV2A+AnG3+zjZPq4ouvkEnst3PyKhG76LQzm/Rj/+bU7sVoAjELx+X3Iwqzqmq14HwPRS8h2HwODs5n6hq6ZA2qFvX2EZbDamDEySpmK50GCBfJJ9NogKOw4BwiFoViIzgeOKWJaUfehahLJgvqKAshzjBr1VQaoEg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mWhk7wWlDMg6Whmoyi2EOjXtMn2SVFV6ZyMv+MnRabQhVTMi9IYZdu3oJhmueaAB+h9ZB20Q2NzGx2IXbt6rZ+CaK8WY2QG3CeQ9jI7jneglX0jlFUvqzEu2aTrUHidzbQkUU8K2bw3RLrW3aAk8Xw1EAcdLccQQ2pKmHbXizNy6B38DAwZ0tijKgW+0oabUvE7FegDYM/Z2KqDYG/rWTGUZ9tYa52jBiJL0YAfAMRt7Lp3XKJgIXh0QAKz5ywkufFT1wv3T/jc11v5IKxH69QK5I8XTn80JLN/IC6aFHFV2JEdIPb9oqmRUbsNoMHWnsp2J9/y+GwvNY8RmBiHL7g==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 06 Aug 2021 16:06:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.07.2021 16:10, Anthony PERARD wrote:
> Those two dependencies already exist so make doesn't need to know
> about them. The dependency will be generated by $(CC).
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Unless I'm mistaken this was actually an omission by 68b1230ae393
("Auto-build dependency files in hypervisor build tree"), which
would again suggest this can go in independently of all of the
earlier patches? In any event
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -84,7 +84,6 @@ extra-y += xen.lds
> ifneq ($(CONFIG_HVM),y)
> x86_emulate.o: CFLAGS-y += -Wno-unused-label
> endif
> -x86_emulate.o: x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h
>
> efi-y := $(shell if [ ! -r $(BASEDIR)/include/xen/compile.h -o \
> -O $(BASEDIR)/include/xen/compile.h ]; then \
>
|
