[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: work around build issue with GNU ld 2.37
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 10 Aug 2021 09:33:12 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xeNzRTaq7EbzhFto09/4l3icPuceGhXuRsWUN5jnfEY=; b=Z1ni+2BxKZRIO7W1L8sxmB4yM8+oSfHbKRdCCapUUu/yiqeT/FGr3whO7YMv2kgp0fRfe4nSMFe/fEP6P/Ri4OKJhofFiMZiH/CKKGvnFQWQ+YY1tGNYkR9BusM2z7GI6EueWb6J178qvn1HjUJauhDipnq1oLYcxZLdAfcKA5Jnvf6xW+hijPVUfZSyFn7J5Ria0OZDMfD9wARGdSxk7nyB4V8Ckh6qbLpGsKtW+Mtsrd7B8yCAvyPT4vFOp55VfOJ/IfrGSKyZaDDb9+sdiMRXJQ8Q+j4YWZgxn2g0Gn3XR+xKR+4d9qdrRZfjPOkBbPgP8HcMV0KfHhZMTaBu5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Evx4kcd2udZC6git7ZjUvNPTo4zWRZ0FK59fp54zffBaPjGl9kbrkxYMWyXJOEGjoeQ9PTcOgcfiFhmU8didfTRXZc72COVK476Wrukvs9P+sFtk9rAIGu99JLkH7l4p6oGVlcQuG/6TbltnLHfNigvR/WkmeTzSP9Xwl8Z6l6qyVWsXZU2AV9qjJfQd38EIo4CLowfOcvS//L/aNflA4wHtMn4gvSjEg3EyGzH2mrKjDTnroyX6Vk5VPBxxNrHp4uekYfvN5I3MW6DmHyl9C/0zcBl5Y/2dxYyPpadl3c37e6FjWpAavpjK3LCjKreU8TlDQuAPP0s8wJ6v8X/Zog==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 10 Aug 2021 08:33:44 +0000
- Ironport-hdrordr: A9a23:tDWVuqsY1/WCg9QsqudqtZet7skDgNV00zEX/kB9WHVpm6yj+v xGUs566faUskd2ZJhEo7q90ca7Lk80maQa3WBVB8bBYOCEghrOEGgB1/qA/9SIIUSXmtK1l5 0QFpSWYOeaMbEQt7ef3ODXKbcdKNnsytHWuQ/dpU0dMz2DvctbnnZE4gXwKDwHeOFfb6BJba Z1fqB81kedkXJ8VLXCOlA1G9Ltivfsj5zcbRsPF3ccmXWzZWPB0s+AL/CAtC1uKQ9y/Q==
- Ironport-sdr: /ysuthRUydvviW7TSZc4+sAOvzBjMRBOvqS6Kdg9Hff9ilfhFgVgcgRMa2YrT2pHp3kl9mlXc8 Or+s+/K8qwyIVZkTvdCQQgonjSakyO5yR5M1wLxsp8oMcu8+HX/PeaeENHFSv5+bbaGFtNE+Jm BK0uzVd8tyiIKxLYs/6pusdgwWzS7A4Kb0srknqf4m8kIe2l5djWXwADJ92iP50YOPOF8t+qur wHydyKw4bs3U2rTu6RMwdWrblc1xUSxI/LCwuVsdHVga0Vfq+6TWGL5zhE43Vl+h7wRn5+siTQ ileHR4Nk5Ouf+HDfsnsc5Lbf
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/08/2021 07:37, Jan Beulich wrote:
> On 27.07.2021 14:33, Andrew Cooper wrote:
>> On 22/07/2021 10:20, Jan Beulich wrote:
>>> I suspect it is commit 40726f16a8d7 ("ld script expression parsing")
>>> which broke the hypervisor build, by no longer accepting section names
>>> with a dash in them inside ADDR() (and perhaps other script directives
>>> expecting just a section name, not an expression): .note.gnu.build-id
>>> is such a section.
>> Are binutils going to fix their testing to reduce the number of serious
>> regressions they're releasing?
> To be honest - I simply don't know.
>
>>> Quoting all section names passed to ADDR() via DECL_SECTION() works
>>> around the regression.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> I guess we've got no choice. Acked-by: Andrew Cooper
>> <andrew.cooper3@xxxxxxxxxx>
> Thanks. I see you've committed this already.
Actually, it unilaterally breaks FreeBSD builds:
https://cirrus-ci.com/task/5417332467040256
I'm not sure why my build tests didn't notice, but obviously this patch
isn't a workable option.
~Andrew
|
