[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/xenstore: link in librt


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 12 Aug 2021 14:11:32 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2VXQ/m6HeLComOVKMfR2AcrhEukYLkAe4zniaD4SiOk=; b=dxGsYacYvU/8m5eFVXndtPL83C7jPD3jiJIcCnF+u6xeM69cR/DaK3yaHRmKs3OpOpkQDGbDI1IKlDTAuYanaIWKuQqxOKiCqpYfOG9aX4+rPOk4p7MIpwWeY2znycbOBJuwPG60HGspLbqouXhbDOKMM7oAV3nAS9pkQmf1ESsEkI9uL18jYA9zN+Y7sLEsd/LDT7lLI+MzIndMKsd6blKsR2U7fLYMUMgwXvQUEdzVmF1eh5vHjRaSmOzUCZmuNSMCkmKFfULY/8oAb1ySNqO7nqt0yZKMVPo3H+iYG/FR3VvxxEVdaWUgOod5zZzr5DdngzkC/PexQ8B0q9WTIA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mAb8JkeCNnh8h4Q8AldxoxdxDL8lxpKph+rXMkNGo0tWbbRDtIYhStGAaC32rB+2m/zVUEyLGgX9xbjFcHsGOJWEIeQd66JCFoATAEDeqB9x0y4tG2PB6B8DFoff8+IiH9MPyungrYyLF9SfbDiiKMCo1xmFjrftaWvwIvqOx/vvNUjZqZfRNo4s04upf6jKepI6D0T+vQ/ZjXtqwMwI1N6x1xv8UyOFV7OwsLcvFLlqT+NrQdo1cqLkGbCv3ogQBLYePKGYdQz+YSs8BqloVE0aNR0SbUAArJPmPVRpAgrJRew2sKL8/eGdyOjaLYnoYl0N0GVznD9Gbxrwwj5gEw==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • Delivery-date: Thu, 12 Aug 2021 12:11:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.08.2021 13:24, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH] tests/xenstore: link in librt"):
>> Old enough glibc has clock_gettime() in librt.so, hence the library
>> needs to be specified to the linker.
>>
>> Fixes: 93c9edbef51b ("tests/xenstore: Rework Makefile")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> Cc list based on the assumption that the XENSTORE section of
>> ./MAINTAINERS probably ought to list the containing directory.
>>
>> --- a/tools/tests/xenstore/Makefile
>> +++ b/tools/tests/xenstore/Makefile
>> @@ -31,6 +31,7 @@ CFLAGS += -Werror
>>  CFLAGS += $(CFLAGS_libxenstore)
>>  CFLAGS += $(APPEND_CFLAGS)
>>  
>> +LDFLAGS += -lrt
> 
> Don't this unconditionally is definitely not right.

Assuming you meant "Doing this ..." - why? If the concern is that
librt.so may needlessly get recorded in a DT_NEEDED entry, then I
can replace the early addition with a late

LDFLAGS += -Wl,--as-needed -lc -lrt

one.

> How old a glibc are we talking about ?  (I looked at the minimum
> versions listed in README and there's notthing about glibc; perhaps
> should be.)

I've hit this with 2.11.3. I guess it has been made available by
libc.so from 2.17 onwards, considering the symbol version is
GLIBC_2.17.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.