[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/pv: remove unnecessary use of goto out in construct_dom0()
- To: Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 13 Aug 2021 16:06:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ruYCt2JKyn4B3mc286X/id6dOyCoYFUnChvb27HZxc8=; b=RVohmispn5LSCLgzbgAXDv0qCwvzAWhlPOUtLkrNUYgIuHm7XWLrTjKFqufUN4r+U3B5BYK6lZqtrzr5yS1L0EXOx9oBiW9sKbDqcow/Ok7ne6SnRRG3IGg9pnhjn37wCvXiUVnWphr+6Dp9W53+MYQqA9aekFg4DueGABmLV6g/MVyzyTHPkC3sIiHTXVPLZJeg2nc8r9oYxZqzRh/JmbnSOojEt2lG6CyA2EtFn3e/p/kNRbiK0nm00hxVkH8qWf+P5GoX6uWDacK4IvNmu1mtfyy15vJk+6m9Wmz5H/lT+SKJtW3np1W2AbR7Mjw6R/Jg2z+9H7LRzJ3Xl5Bzkg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VA+tjZxMBvhRIJHtocQ5p9ha/EnGK55hJvyzeGzKK4cYuewlpRHKmOEdI3nQZLciKNVw1Qz2N0t4IUn3M/o1CVuG8qPnf0uOodXqs3iY4muWCSfawKWHQVBl/UoMHyu+EI6DD5s9lEcQaqbiuC5KAe9E7SVww4c8XB8wfXfbO+Z7s6hKv0nqa/kLTp0Oa43F3xEORHClUDj/7SEWTE9xaipLXDutJdXrXFAvbmw3b5THw7r7BDXw9kssapwgbpUwp56mH1Gbrse/Xq8Nu0067ubGZQN0IGsZ7IG1lmHLW0Y6nbuhmBKflZIrYuTBcjkBsdly9JYc/aLkWdlVpzE54g==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 13 Aug 2021 14:06:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.08.2021 13:02, Jane Malalane wrote:
> --- a/xen/arch/x86/pv/dom0_build.c
> +++ b/xen/arch/x86/pv/dom0_build.c
> @@ -379,8 +379,7 @@ int __init dom0_construct_pv(struct domain *d,
> }
> #else
> printk("Found 32-bit PV kernel, but CONFIG_PV32 missing\n");
> - rc = -ENODEV;
> - goto out;
> + return -ENODEV;
> #endif
> }
Afaict here you're fixing up your own earlier patch, which hasn't gone
in yet. I did expect you to alter that patch and resubmit, to then
omit this hunk here (again in a resubmission). With that the patch here
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Note that generally when a patch depends on another one which hasn't
been committed yet, you'd point out this fact in a post-commit-message
remark, so that reviewers (and possibly committer) are aware.
Jan
|
