[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH V4 02/10] xen/arm: introduce new helper device_tree_get_meminfo
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
- From: Penny Zheng <Penny.Zheng@xxxxxxx>
- Date: Mon, 16 Aug 2021 05:27:40 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BQbwQzP/Vhqpq9jFB656TS0YekquWI1007vKKnp85jM=; b=WdR+NbgqXBDWYimOWUhkX6dS7p7ZuSjn/IWC4zwLoRgQPhSQAuJu8csMIDx8HcjapDauVvNi+tmCwN2ni6HIiMkhvm1Fzq6usSxFVgMcwosg10hGSEJT9SpTkQmsGJFHdbvRQEXih1+ApUijewf4H0dOgs+zon6g+bvKZSO6JZjsHE6/YxyC9aEfnV4/ft7MyXmB3rjmGXZ2hA2a9GlQ6rwJKOh+OxQU/xBZpggMRf6XaU2/6vTAvLxBiqpYqxSMJdE5Vih4MzkLj6DToRYkq4I19FQja85xKQEJMwIiuVjzKc+wqqLMLAEOtD6MUGgHHsxRU8tT9LgyTTBeyX5xag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=imCgqtu/ny0B9QF+/Mlh5OKD1zrJbaEyAknaHUbPgWr3u8ZE7kLqaPw7uNLh13IeBwKaYMgVaa1BgG+nsWldVlqGVQ3RVsKYDWkHVgmlNNCujIbHqb7PeKH2BhMTAz+NCeuiJl4filVlwlkrUWGEykN+8MrXzF5ilN0pIaJNMwqNruxCiLC1sw+ow9EhO5B8J59iCidVsyPVgCEb2i4/bXEWgkeEkktf9aNSpR3gMHuh6aGRg1v5S604iu8FVrioNfBtlNKba/qK9rHuQeEJhad4EV8Fd6p7bbhrwo4w2LR4g+Iv6I1CQJc+dsn5JrD4QCV9VTpqrqlEtV50Hu3M0Q==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, nd <nd@xxxxxxx>
- Delivery-date: Mon, 16 Aug 2021 05:28:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXg5tWRKlXTTX13kmrw+bRqBLzp6tuZDkAgAdTFRA=
- Thread-topic: [PATCH V4 02/10] xen/arm: introduce new helper device_tree_get_meminfo
Hi Julien
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: Wednesday, August 11, 2021 9:35 PM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> sstabellini@xxxxxxxxxx
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; Wei Chen
> <Wei.Chen@xxxxxxx>; nd <nd@xxxxxxx>
> Subject: Re: [PATCH V4 02/10] xen/arm: introduce new helper
> device_tree_get_meminfo
>
> Hi Penny,
>
> On 28/07/2021 11:27, Penny Zheng wrote:
> > A few functions iterate over the device tree property to get memory
> > info, like "reg" or "xen,static-mem", so this commit creates a new
> > helper device_tree_get_meminfo to extract the common codes.
> >
> > Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
>
> Ah, this is where you did the consolidation. Sorry, I didn't notice this
> patch.
>
> In general, we are avoiding to introduce code and then rework it in the same
> series. Instead, the rework is done first and then the function is used.
>
> So can you move this patch first?
>
Thx for the explanation. I'll reorganize. ;)
> Cheers,
>
> --
Cheers,
Penny
> Julien Grall
|
