[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/ACPI: Insert missing newlines into FACS error messages


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 16 Aug 2021 15:59:52 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHGdIT/k1e3/378aeJhojl4+/o0GWC7nFlC5UmTd7mw=; b=G5ldgVK/B5UaemBRuqajOXd3IBcYP0jRmWA9GLNkPmLDNKHk3eirC/slzQjJa2gidBEt5zxkEmx8QUjuuaWrIrWon4EmhCr/DdGOEg7UxgPETJ+W0a78lkqvJJJS/z+WX5mqUEgUFfqY4rnzR/MN6VZaO+l7TKvIp9Ll9AEDBKOeOXug5jIfcd/dhkRK6AbbpNDYnRgt5Qlr3medXYptlBgzGw1os26K1V7WNxAo3mDUs+c0h6oSDZoXhbpfiIypXv3BWe14rtOxv1tB3vu9QQ3KBFtGI456iQDfBo/zSXiR0DnHBiZLwRis4QbeR7s0WoPBeyL7ga6lkCDdRK2O2Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iI9zSKteAAlV9q45p2g2Gb2xs79c23cncpkmX6sUhC+JBikmQL7eMyBgwKj4z+rMcu3t2g2eKj/Jc1ZLYfIinloEQPom2/2UjvJBZDEUV6T3As9qJcTdpKnb5H+O/KI6tGbmL9BVQt656q8Z5HdjrmqZM6OL3BzsO8WpbMa6fuTljzI8qOb3F3nkPLzNycBO6C+AqJkBhnVEy87WiX/1aTQzLO3y4PI2UyoOvgXfMWMXvCf9s/1mn25DWIxYw6KBPZV5bQlACi28oi1DFJXQK8dB1ZvnAKd9lbB+9QMKp4zIfDrz7Stu01leFlPZc0xYYvqrui17n8OrPZXgvZPq9g==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 16 Aug 2021 14:00:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.08.2021 15:58, Jan Beulich wrote:
> On 16.08.2021 15:35, Andrew Cooper wrote:
>> Booting Xen as a PVH guest currently yields:
>>
>>   (XEN) ACPI: SLEEP INFO: pm1x_cnt[1:b004,1:0], pm1x_evt[1:b000,1:0]
>>   (XEN) ACPI: FACS is not 64-byte aligned: 0xfc001010<2>ACPI: 
>> wakeup_vec[fc00101c], vec_size[20]
>>   (XEN) ACPI: Local APIC address 0xfee00000
>>
>> Insert newlines as appropriate.
>>
>> Fixes: d3faf9badf52 ("[host s3] Retrieve necessary sleep information from 
>> plain-text ACPI tables (FADT/FACS), and keep one hypercall remained for 
>> sleep notification.")
>> Fixes: 0f089bbf43ec ("x86/ACPI: fix S3 wakeup vector mapping")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I'm curious though how you came to notice: I hope there isn't any
> hardware/firmware actually triggering emission of these log messages?

And actually you answer this in the first line of the description,
while when reading I skipped straight to the quoted output. I'm sorry.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.