[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/PV: suppress unnecessary Dom0 construction output

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 17 Aug 2021 10:44:13 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SHJ9fgTWaF7qMHftEoAjhmjVTM7DO3Izy/wkx2lUCrk=; b=d6bVO5osLp1f9cYBtXECrrtppjKqghAW9rQ2jbIcn/nR+4iWqfaabFVTw3DcHAHhK2D5edUUEcKxcn1/hVXMY86ns/RrIgBmh11TGk37UQITxNFXNC+VINx1UoEuVqFiJ/LklnKKL4g0Q4LljLHtnicmKboEK2txF7pWQ45B9af4dKa3s13dvutw9eMnwlTX5vrmn0F6h0RfY02RSaiIson5z6xBExcgIjPEgLy4jVal2NSl98qwvgLyAh3TENJgvbLz8lJz/ScQbj0Qr/CvjChu5LBzvKWAm4iwY34EvZDWEf/k2NjFHkYBzFHEJh1W+9uWVbQFCfSfXl34amucPw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lAcAXJntY8otQkHxN/hJTueSaBnEhZKELylgzwAx3eN5tA8+sAty89xiDSHcBznfRNOGO+XEBB99RiDfzhYCia2qmRd0rvpjpA2IfVQPWDWMrrxA1iwM1eNRX4FD9Mcnm5JYIJq42jRj2A4XYIztU2z+C1XdiPixyMDKBUcPQPlf2gry0GfzzIVfYQsKoierhOIKDLEkqDpjuIEHNnh5Bfl5ZKRNsymXGr6YtUGqZS/E3VO/IIWi0HDvsKftZ0+Z9a1zKc7XrAoPthARzdq18zfhw+eKRw4eKI427N8iHgTQxfU33fPmGtQP2AyaMgFAkj8j8dfODiflE4XzMTBwAA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 17 Aug 2021 08:44:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.08.2021 18:20, Andrew Cooper wrote:
> On 16/08/2021 16:30, Jan Beulich wrote:
>> Especially with XEN_GUEST, being a prereq of PV_SHIM, defaulting to N,
>> v{xenstore,console}_{start,end} can only ever be zero in such default
>> configurations. And in case video is the only output configured, space
>> is scarce. Omit the two lines carrying no information at all in this
>> case.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> as this is an
> improvement, but honestly I think it would be better done differently.
> Each line ought be a separate printk() in the first place, and these two
> messages should be conditional on opt_pv_shim rather than
> CONFIG_PV_SHIM.  That will also shrink the output for native boot when
> SHIM is enabled.
> It also lets you conditionally drop the ramdisk line which has some
> conditional printing a few lines earlier for the physical layout, but
> unconditional printing for the virtual layout.
> And on that note, the earlier few printk()'s really need some newline
> corrections.
> If you do go with this approach, feel free to retain my Ack.

When making the change I was actually thinking about splitting the
printk(), including suppression of the initrd line. Since you now
indicate you would welcome this, I will indeed do so. Thanks for
the (in advance) ack.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.