[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/cet: Fix shskt manipulation error with BUGFRAME_{warn,run_fn}


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 17 Aug 2021 11:10:21 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UahAwd7emKt9uXo65VJB7SOTs1cwbl6POIJg+90aPME=; b=f+Qjzc16lMWe0ludAUATfZwrHVHvImAr5Ox47w+FCHrPcGRpQCw57WUG7D7ahraFIkHcqYtt1atCmBSVaIMOEWYv6U7JYkkf1ec3WTSpz30dQPN0VhxBMqNH6zEqAUy7kIy3k2l6TCzlO47f5uBC+QUq9smtN+8mTEQ0Wdjt6w5E4lxDSLvdgrz4X6eK7mWrx0x7FTamgrk7JzQ+rYku4R4PJF+oAGfQtFhQUeV6Bq3ih/sm4vOhwUCH3F3K5Qqbs22otGAJmncvs5UlBYRxefNk0CAdHoeG509H7E9fNOPphCES0ZnzdhlRyn0ASaCz60FcXPToNlwBXEsSgcjMzA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NKL81SzcibpVeRlIVoB6FjzCtWdUEiyPR7w4X4aO5JJpyiz7ctn6sXK99T5sStMJH6agfZn17Ye1WOjJDb0zlfArC9G0yB38/GHKBTYJlAB78BgcXqKoxwDGbj1yLWo3CcK5aDCfVFCHLho4Y2s/CSKf25DFxovFTAri11iLuoB+J41Z9vAo2YbUSKdQBBhJ2jxsvH3rcmeCFUvU7dZr8lVQmclW8mnFKbafTQne0sEfZGUL76xSzwa219xSniD95cL8vPxi0ShvLHrFCk88itcYpJ7pa0OMQlWJImEpFYC8k2/G3laEZKIXn/4l1fiob+nuvL2Gwk9J3xjoa2jzkw==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 17 Aug 2021 09:10:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.08.2021 19:03, Andrew Cooper wrote:
> I'm not a massive fan of the large ifdef area.  The logic could be rearranged
> to use IS_ENABLED(CONFIG_XEN_SHSTK) by indenting most of the function, but I
> can't see any way to drop the goto's, and this is certainly the least-invasive
> diff.

So perhaps the build failure I've just run into (also apparently spotted
by osstest) suggests to actually do so? The alternative would seem to be
to widen the #ifdef in get_shstk_bottom() to cover the function as a
whole ...

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.