[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/cet: Fix build on newer versions of GCC
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 17 Aug 2021 13:50:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k+XtMwYBwA6alHSQ6ERZ4HOToe5A2jJvogper1CteHk=; b=Y6mzz4uIUT9crZ1Ndjp6JItL8RRkoLInQJNEghpsZeWeYkht6QgX7lElkssgHD+TmGcbLovnsK74ZoYjlV104+YWBSdReUdbyazsszD11zQK/DQNZS7xnQMX4uR1WahIUBwfErVJzmeniAt3ZOBH9eVB0elhgiSQy+rY4qzeFuPrsdJc1snzOkwTW1Yo+Gu78v2wvce/8wSL5wguBV7WiHyki8W7zF0aLNgsXUgiGTNWIDYNKiTU+zlLlsYg9xKSChGz30nZvblerGHF2Zy7bC99LsKYCBeAPHEnREYY0NwWV0Lp2b1BhU7vhhfOazQzdJruZbHtC0wB21i9FeGXfg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k0eJgOXH31SiKxmF1VV/z/pVNMdS63305GesV6/mQIvMjJTwMu3WNvA6SmW6FC4oDTXmX6TU4OF+QJ8c/E0mz4yGtmdoE/ZBKbYLWurveOS/OXlBMnp5MxFabm7aCt+iVp3btVeHp81oWaC3KxKE09RjfsJc/UxsyPnvNSx+6VvQZeOEyQrA4twQAW53Ijita2LIjAVlOTpEtiB/CCBODlSG67/C0IUL7z0Tb/4WW4k3iGcOOp0opVgLQ3LGZ8OGbUXm2rHoOkzTS9O2//cqpWDuAc4l4OPUHBX5qXr99tw/maCFkBa6kHRUn7q3HiiLHg8Wv+OlpxLk7e/zowX7xg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 17 Aug 2021 11:51:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.08.2021 12:56, Andrew Cooper wrote:
> Some versions of GCC complain with:
>
> traps.c:405:22: error: 'get_shstk_bottom' defined but not used
> [-Werror=unused-function]
> static unsigned long get_shstk_bottom(unsigned long sp)
> ^~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Change #ifdef to if ( IS_ENABLED(...) ) to make the sole user of
> get_shstk_bottom() visible to the compiler.
>
> Fixes: 35727551c070 ("x86/cet: Fix shskt manipulation error with
> BUGFRAME_{warn,run_fn}")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> Not actually tested. I don't seem to have a new enough GCC to hand.
Compile-tested-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
