[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: S3 resume issue in cpufreq -> get_cpu_idle_time->vcpu_runstate_get


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 18 Aug 2021 08:41:18 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q8j5YC7dzVd2OqONZUdcuLZvK1uYaUhuv7Fu3o0wdmw=; b=Z7rX5/YguIdAWlCyXsGuzfrAcXUP/+hmyHAWfAPGB7kcMHeTDQ0a4DNa7HeTONss/xO1aRqLj1anMgIrM6+DXrB5vbF15lUnBIoLn6FThQAULuiw/tgznTaU38X6E5fDGjp6seNMz58AazUYb2rOUuda99wFJAjQWz32Me2vJVkyX95oNiStwCis+WGkMXTc7/JmK8a2UoNhRFEiIGgjaTA4ZfIJ+4N5rKePPBEdMeb/LOPHBhXHkL+O4UBVF8haFIzd7iZN6ipBznC/ZNx1pxoeFFqxXKn8J438T2Qe6teKzasMxMeD1kXFifSyWac4vEfBCY8Lh5O03+MsO3aGYw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FfHwikCzfTbeBG55WaE6O1VY/CguPdBwNjfCLzuiI/hcMcq9A+xY0LJP0OKB2xHta160zmv2BK2DlIBvzVboHeDwGYefs/+oRVfO1McsiiIwfLLLR3QfIuZu7RF++GnYwAWCPKM0mR/aIivQkoWntFLRGT5S4LF1tD0v6sdM75IuKj365bqkcvApnVVtt5mOY0TPEW4LkXdgMqHybq+IcWqGxwvEJZn1VTiQpEqjdl6k+L+Ce5OVLjNQISvchb2+o2yUGhN9m7wwzlWHeuDe31wYvn5OXKB1KmHhdmr17sow8smYpHC9BdrqZk2+bvBejKSAzeMoGsdhm6CVRUDTkg==
  • Authentication-results: invisiblethingslab.com; dkim=none (message not signed) header.d=none;invisiblethingslab.com; dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 18 Aug 2021 06:43:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.08.2021 08:24, Juergen Gross wrote:
> Could you please try the attached patch?

Seeing the patch, two questions:

1) Can idle_vcpu[cpu] ever be NULL when cpu_online(cpu) returned true?

2) Seeing get_sched_res()'es access to per-CPU data, would it make sense
to move the cpu_online() check into there? While I guess the majority of
users are guaranteed to invoke it for online CPUs, I wonder if there
aren't any further uses on the CPU bringup / teardown code paths.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.