[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/4] public: Add page related definitions for accessing guests memory

  • To: Costin Lupu <costin.lupu@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 20 Aug 2021 11:06:41 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DcLHc1LRBfARLQL7Na50Jy6YNFFLfZ5cK1Nuc1t6p4w=; b=TyBmxhFjwtPai7cFe7ksWKXfsGf7rnEwJgYDN97Fzpg+90RAf7ZZ+3Tk/Tkgpl5Zz+hr7eoMm2ZsPnkYcWAex5jKForyJznLntuJx67iBNs+XC1LTHqOBbZYXK67+oe5AfhxuAhq0v2Z/+pJWoi4w+6JCOcKydvLKjZeWf9f6wazqO6q8uqP/1/GKSzEYxYCxONnVLulhtDzqXhX7gZcRW9jBvElIzGAFAqjHkz5PKmtQy56Jy92aVR3veRW4er2LsmaFxT+kVhI2SS7Iw+Z9BzujOsS+Q66zNfI2BbOtJQ4dOT/NpGsAxKlmc7yX4FdBDpTMrGTILuoyizqu9imnw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MEprxNZSfU2uTPzJxXTUEirqLccwQi5kguWFU3VUC4B1wR725dmJhoDLczmfsKZVrxYmqKsDBGqtVDA+viTGEPtt6Ry//cgGhxs1ht7fdwGB3C+9BAqCtjeOPAwVBqSjqaEN3eRGAaO8VctB0bFip5NL4l+br7cNem+V59hMjNCA48ONrvc5So48+RbCzc4+pDFpfk1RNGCn0Lv7o6qwRscSunAnro6wlPEbnsrzMCwEfNmQaHQMQqnvQyPVuIWP1tSAosS/5hZMVIXrnH3hiS8jQc0VkLqyEpPg67r2KJcIn61/5LHutiC+owA99jPof379jV1ROB7JhwvdLs3/Ng==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 20 Aug 2021 09:07:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.08.2021 09:44, Costin Lupu wrote:
> On 8/20/21 9:52 AM, Jan Beulich wrote:
>> On 19.08.2021 19:50, Costin Lupu wrote:
>>> These changes introduce the page related definitions needed for mapping and
>>> accessing guests memory. These values are intended to be used by any 
>>> toolstack
>>> component that needs to map guests memory. Until now, the values were 
>>> defined
>>> by the xenctrl.h header, therefore whenever a component had to use them it 
>>> also
>>> had to add a dependency for the xenctrl library.
>>> This patch also introduces xen_mk_long() macrodefinition for defining long
>>> constants both for C and assembler code.
>> I'm still missing justification for the addition of a new header, especially
>> as I don't see that header to gain much more contents down the road.
> For the first version, since it didn't need to include other headers, I
> thought it would make sense to isolate the definitions in their own
> headers. Now maybe it makes more sense to put the definitions in
> arch-x86/xen.h, arch-arm.h and xen.h (the latter two) respectively. What
> do you think? I'm open to suggestions here.

Well, yes, the headers you name are where I thought these new #define-s
would go.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.