[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 13/14] xen/arm: Fixed error when PCI device is assigned to guest
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Fri, 20 Aug 2021 17:01:59 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pJ6+97H3saUxhivE3cn8tqVpZGQmL7lGL4gSErrjN0w=; b=Esef3ezN90GjDrkcVEoYfVsG074yvl4/KQElivVCqtA+K1BaBbsq6pK06vOxhrgX2z8XSkumu/GGw/drpSL6XkI9iUAAL0ypOhvvEH+ROjqaoYMLiBYVpd1HUXjFo8a6bd1GF1tEjScjH+tigTfbXKgvW97NghBTh9P+w1RIT5XVbTQihiQBItIlAXy/fTjZHRZkLV3OmcaJk4my31jNT8wAojlqAkn0mI1D5v3tvl0ClH0kE/LQusVqxPHbSNzKNqKZ5ck2TkdzCfIeKX8ktyhTfTeq3hLOgyKN9ZlYnIGhrmi2lzfl9CrEi4ql8xKmOIfIJHn35zyzzDohMaB41g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HeHdaAsHL1walq0di9yCZRMGfBkXTJ0oQiXXX1eQzSoHIT+BknH85ehrBffbQmuh5aPNWXpZpTd82y+fFGtw3CFNw7dC5LEgEbar0YPFHORGhCNtoz49VI/4VjuqdUgDoOh0FKyrI7liVdRr5xDYaAzU6cRmWd5KKXp6WadDwMgydQi6zlin1vU/3OIH8TpHY3zGS2GGk87PuTFj64aCZnZbz/aFxTIf2UDi9ekhhiLQBihXbq1/OWWq+eIptLqZ0yoikpm3PwMSwG+m00+XvCuJrfDWgGv/LUtne+VmjxWXSPibl+O2QUdS8klu3LuIfh4fBl7c7XIh2FYHHEpiTQ==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 20 Aug 2021 17:02:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXlPL/fNVOYnE9fEGgRojjCVjj8at6vRwAgAHjK4A=
- Thread-topic: [PATCH v1 13/14] xen/arm: Fixed error when PCI device is assigned to guest
Hi Jan,
> On 19 Aug 2021, at 1:12 pm, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 19.08.2021 14:02, Rahul Singh wrote:
>> --- a/xen/arch/arm/domctl.c
>> +++ b/xen/arch/arm/domctl.c
>> @@ -173,6 +173,8 @@ long arch_do_domctl(struct xen_domctl *domctl, struct
>> domain *d,
>>
>> return rc;
>> }
>> + case XEN_DOMCTL_ioport_permission:
>> + return 0;
>
> I don't think returning success for something that doesn't make
> much sense in the first place (there aren't truly "I/O ports" on
> Arm afaik) is a good idea.
> Instead I think the tool stack should
> avoid making arch-specific calls in an arch-independent way.
I agree with you let me try to modify the toolstack not to call the
arch-specific call.
Regards,
Rahul
>
>> --- a/xen/arch/arm/physdev.c
>> +++ b/xen/arch/arm/physdev.c
>> @@ -42,6 +42,9 @@ int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void)
>> arg)
>> break;
>> }
>> #endif
>> + case PHYSDEVOP_unmap_pirq:
>> + case PHYSDEVOP_map_pirq:
>> + break;
>
> Less sure here, but I'm not convinced either.
>
> Jan
>
|
