[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [XEN RFC PATCH 09/40] xen/x86: Move numa_add_cpu_node to common
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Tue, 24 Aug 2021 04:18:57 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5B/xjtBpUOxDahcCe8b/trxJvEWYMcCovUcpTJ0I3SU=; b=OwDNlicXpPjYykvwpV6ideVVn62djmt6CrICZPs7jpmzvSxr6n1cAe82ZcKG5f/ySsxtir/lbtz8cbfmX1be4IejLawgikk0JLqbhR4Z8QYDxAFAlfKQGAyEyqKYmDgK1C9CU9KjImohAmdN5AnDjcbOJ9IfTrJ4cjk4Nph8qvsozmC32kPJkXaiDfH1eH48/UkmPNuYepUjsBsVRukZZQkiphVm4tMHb5APsqYjgf3DxkkRU/mbeBqWsukkjdVuFdGTkrT0dAM211Xpkkxvla0H6oYGOc/hv4uuPFezCaA6rcsVjTw/Nsppqig5oH+wn+aqoriuqyuCFwnuu+m44g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnqLjSUoUdXlGnWpX9sieRpofaZUlSK8LKt9rFPn5l2DKNVlbnJKKlmSprSX7t4hQ5yvhLOx/HbG40r2yHleSz0bZMiov6m/tDi4EP6hRz2+K7eSVs4TsBQUfPEi9rtYNwxSpL5VYJLDs75AdOlI1uqJg9jMITnteleAlAHb+OxA+Toygubz7OIzfDicscerl4HpS39wkoBCO+IedJdcbz1fw+NF3tRyNRe2RYIx6POH903kXxHh/Wx2sZ/97FOSf/mNjF0xyEhGHqiGRsmj7tbu/rOF2WNs447Ykh+P6zqKNewTFJnMGvr5yw3BkmQPSnH0lB9Y4pGe3xfQZ9+7BQ==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Tue, 24 Aug 2021 04:19:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXjpsxWzM+1+Y9tEG1bhQyDwIVUKuBcpmAgACuDNA=
- Thread-topic: [XEN RFC PATCH 09/40] xen/x86: Move numa_add_cpu_node to common
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: 2021年8月24日 1:54
> To: Wei Chen <Wei.Chen@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> sstabellini@xxxxxxxxxx; jbeulich@xxxxxxxx
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Subject: Re: [XEN RFC PATCH 09/40] xen/x86: Move numa_add_cpu_node to
> common
>
> Hi Wei,
>
> On 11/08/2021 11:23, Wei Chen wrote:
> > This function will be reused by Arm later, so we move it
> > from arch/x86 to common. But we keep cpu_to_node and
> > node_to_cpumask to x86 header file. Because cpu_to_node and
> > node_to_cpumask have different implementation for x86 and Arm.
> > We will move them to common header file when we change the Arm
> > implementation in later patches.
>
> AFAICT, the Arm helpers are gated by !CONFIG_NUMA and the ones in common
> code will be gated by CONFIG_NUMA. So I am not quite too understand why
> they can't be moved now. Can you clarify it?
>
Yes, you're right. After we had introduced !CONFIG_NUMA, we can
move node_to_cpumask and cpu_to_node in this patch too. I will
fix it in next version.
> Cheers,
>
> --
> Julien Grall
|
