[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 5/7] xen: re-define assign_pages and introduce assign_page
- To: Penny Zheng <penny.zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Aug 2021 12:54:46 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S274DjccSW/v6nWZGszRzhg0IhZBbtOuANRVpp83PnI=; b=NdldZ1z+bEFYXLlVjL0T3OWQFfFpXhA//d4rlZKH8gnBGA65KCn9mD+As4w4qm3gupoByy4HclDg0OmeAPpmqVz81g+WPhVBbpHJUfRIiT98IzbN5HOCCikMXiVYXAdwbT+Rmz5o+AVLcAA4sMyipF/9QoD7Jmr7GGZStJ+fKdyGtFKaLqH1grDEHDzshdrsKRIsNMqou3KsV69Yo7wRRO2R0ovphxsZr4HrpzJ+0sfBcnrpACfsM+WB0/jnXqEFJyI+32nRe9Y2LxCRiJwbLrjgT1XSjNDNNk4sLCe5zwBjxAqcrEMYJBr6yKnMUX2wakmo5XJq505yMLPUrDxuTg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRdbNXTBvT7EgnH2mJbsK5bOUZlv/oppNvzBE0l/v8qjkNdJRCP6GLNIXdo+czr4gxXZgRRMrYS5oMbFInSh68WjDmj/COzgvl7rG06xUC+crfvjyMdnzvzchqkUOYjfPSowi/n/br69ce7aM9PHIn1rSsVJwZaFDYXrrZBi6Myty06oUk5PGOGi4Auw0ThvQQi4IiNDL7hLN3R8uwZDO08uUQ6dU7LZHHwtfDRZ7r6+Z/AN2KWapEXNH/iFly74o3J7DVgJa+But4PhQx4XHZHHIYhf/ko9tTm3aDavBsg3rGw08coK0+MAx8oR5pP3/qMWkSSr2SjKe8UyVu/ZZQ==
- Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
- Cc: Bertrand.Marquis@xxxxxxx, Wei.Chen@xxxxxxx, nd@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, julien@xxxxxxx
- Delivery-date: Tue, 24 Aug 2021 10:54:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.08.2021 11:50, Penny Zheng wrote:
> In order to deal with the trouble of count-to-order conversion when page
> number
> is not in a power-of-two, this commit re-define assign_pages for nr pages and
> assign_page for original page with a single order.
>
> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
This ...
> --- a/xen/arch/x86/pv/dom0_build.c
> +++ b/xen/arch/x86/pv/dom0_build.c
> @@ -557,7 +557,7 @@ int __init dom0_construct_pv(struct domain *d,
> else
> {
> while ( count-- )
> - if ( assign_pages(d, mfn_to_page(_mfn(mfn++)), 0, 0) )
> + if ( assign_pages(d, mfn_to_page(_mfn(mfn++)), 1, 0) )
... is precisely what I did _not_ ack. The re-ordering of parameters
should remain as you had it. The request from Julien wasn't to undo
that, but to harmonize the new function's parameters with those of
the existing function.
Jan
|
