[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] arch/x86: rename debug.c to gdbsx.c
- To: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 24 Aug 2021 12:31:13 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Y6QpED9NF6eTrwNlrEL0x9inj4iERROlk8v68fSxEk=; b=CF8EFfOn23lwJliLt3gCVn8z1uot7PsTAhHZxqYVEARzs0UZZx1Z6srwHX5N/wvBNh4mRuHGWvqvPSSKvgSQ4MK6vAMleX7rAqBaoAIkdBjwZ9u36Pk0u4SpdD6kAz/MkLX0Epg7rl9dv55qPj4N5eDg3psoHCnfgyzXQIoYXqAQDn1mAjQ6Q2+mNEX2KcHA7AvrHVlTihubynFpigVgyd6ZKNdH6SxeTUax2uBwoT9NqIF9HXSlbSmc06sC7obcMuenhcPMmNyH/UCK8EtIfZWjXjEUPBd8T5pl2w8AMJjRd3YJq35vyR8gh9Irm+o6YCn+X2KOzGuVhmBe62rz/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OeVGh31uUE9wymK4dXYqU5nJ6Dr8MbuZhQfHV5+NNAVD0wH489bY6pCjW+WyEqwT11xoOX6yzJmj8W9a4tCbhsnTRZJGFuZglgwCVWhFPjPSnRXnXqxk7D5nvU+yT/RKfLNEANniSlFB9qedlTAzm0kYlw+2uFeKVhHLGVD3XH46fXZB2iP+vxlVtuo14dJz2piTeNPg3D5xftiin0lJHh16UuJTzVIqUUZ/jJ6HnpJ714d1p0vX4mMZ+fm4KjZzMdHVVmI9vw7hJbIc1QjeRHRdQVBqwWYm9r8ETyt3iG2um/OfGrY5PuzEMxH4wigb5C03gG6EkBXyxYrkYDEiQg==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 24 Aug 2021 11:31:28 +0000
- Ironport-hdrordr: A9a23:rgm7cql5D8PytzpXvSIdum2fKCrpDfOpimdD5ihNYBxZY6Wkfp +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPpICPoqTMiftW7dyReVxeBZnPbfKljbdREWmdQtrZ uIH5IObuEYSGIK9/oSgzPIY+rIouP3iZxA7N22pxwGLXAIGtNdBkVCe2Gm+yVNNXh77PECZf ihD6R81l+dkDgsH7+G7i5vZZm8mzSHruOpXfZAbCRXnjWmvHeN0vrXAhKY1hARX3dmxqojy3 HMl0jc6r+4u/+25xfA3yuLhq4m2OfJ+59mPoihm8IVIjLjhkKBY5lgYaSLuHQQrPu04Fgnvd HQq1MLPth16VnWYmapyCGdmjXI4XIL0TvP2FWYiXzsrYjQQy87MdNIgcZjfh7Q+yMbzZxB+Z MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjlREOLFuLYN5nMg6xgd4AZ0AFCX15MQMC+ 91FvzR4/5QbBezc23ZhG9y29ahN05DXCtuenJy/fB97gIm2kyQlyAjtZUidzY7hdEAoqB/lq D52v8CrsAXcid+BpgNd9voQqOMeybwqFz3QTmvyfmOLtBPB5v3ke+C3FwC3pDgRHU59upGpH 3/aiIuiYcTQTOjNSTc5uwFzvjyKF/NFQgFjPsuvaREhg==
- Ironport-sdr: CeP/0QVDdfUqVwjc+tmmQgHBviagfe+IrVaUNW8+oRW6gFq4LONLKFCFr31mJCwaqLTxpBJE9v g06YejplDhdrcevwIrzep/gJ1A8C6bi1xHbSmXk4w7WhyjZMjO0ezySy1DO9HL0W/jGPulGrDI B5UF3bG50trR0//ifydNO75j/iNH0d0b3FE/FQOrm10TOwNxe5mF5umeAwstDVSKv5Ce6/uSxD 4tOa736JtWRsu/Xz5S2CHKgCXUeyGi/E9FNGUsl2DVYC3lr3HRsep3J9HlwWHgZmy9Gif+QKMF bVjozxxAOzsojf5l4mPtIqDy
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/08/2021 21:29, Bobby Eshleman wrote:
> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
> index fe38cfd544..ef8c2c4770 100644
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -20,7 +20,7 @@ obj-y += cpuid.o
> obj-$(CONFIG_PV) += compat.o
> obj-$(CONFIG_PV32) += x86_64/compat.o
> obj-$(CONFIG_KEXEC) += crash.o
> -obj-$(CONFIG_GDBSX) += debug.o
> +obj-$(CONFIG_GDBSX) += gdbsx.o
This wants moving now to retain alphabetical order.
> diff --git a/xen/include/asm-x86/gdbsx.h b/xen/include/asm-x86/gdbsx.h
> new file mode 100644
> index 0000000000..2b8812881d
> --- /dev/null
> +++ b/xen/include/asm-x86/gdbsx.h
> @@ -0,0 +1,17 @@
> +#ifndef __X86_GDBX_H
> +#define __X86_GDBX_H__
Broken header guard.
> +
> +#ifdef CONFIG_GDBSX
> +
> +int gdbsx_guest_mem_io(domid_t domid, struct xen_domctl_gdbsx_memio *iop);
> +
> +#else
> +
Need to include <xen/errno.h> to avoid breaking the !GDBSX build.
Can fix all on commit.
~Andrew
|
