[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 6/6] x86: change asm/debugger.h to xen/debugger.h


On 18/08/2021 21:29, Bobby Eshleman wrote:
This commit allows non-x86 architecture to omit the file asm/debugger.h
if they do not require it.  It changes debugger.h to be a general
xen/debugger.h which, if CONFIG_CRASH_DEBUG, resolves to include

It also changes all asm/debugger.h includes to xen/debugger.h.

Because it is no longer required, arm/debugger.h is removed.

Signed-off-by: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
Changes in v3:
- No longer introduces a fake TRAP_invalid_op for arm to consume, it
   is not necessary given the removal of the arm calls now precedes
   this patch.
- Instead of defining prototypes that arch/ is expected to implement,
   this version simply #includes <arch/debugger.h> when CONFIG_CRASH_DEBUG.

  xen/arch/x86/traps.c           |  2 +-
  xen/common/domain.c            |  2 +-
  xen/common/gdbstub.c           |  2 +-
  xen/common/keyhandler.c        |  2 +-
  xen/common/shutdown.c          |  2 +-
  xen/drivers/char/console.c     |  2 +-
  xen/include/asm-arm/debugger.h | 15 ----------

For the Arm bits:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.