[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 10/51] build,arm: move LDFLAGS change to arch.mk


  • To: Julien Grall <julien@xxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 24 Aug 2021 17:14:09 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 24 Aug 2021 16:14:16 +0000
  • Ironport-hdrordr: A9a23:8Hu7YKGzzSUIetaPpLqEJMeALOsnbusQ8zAXPhhKOHhomszxra yTdYcgpHjJYVcqKQwdcL+7WJVoLUm3yXcx2/h1AV7AZnibhILLFvAA0WKK+VSJcBEWtNQtt5 uIGJIQNDSENzlHZLHBjjVQfexM/DDNytHPuQ6X9QYVcSh6L6174xp4B2+gYzdLbRgDCYA0CY GR/NZDulObCA8qh+qAdwE4Y9Q=
  • Ironport-sdr: dnobXopqdNOXJpsLdB+i3ZgDPoXLve/USjRuXDvs42LtpRzhOTVWW4DFZ5gVcImctyK18PRpdm gCmtz9BerTHZ89n5Nsx3oD13kZoXMBy5bZhAU5/0XUi0KA1QCTgWrptIvvQbxVlCObg3sRTgvD oRKZOFf48GogU1r58vM6cPzMhDoUi8P4KMDvtm+RvPd+WVemLKk2Tr5kMLke574NLe9JdMVr2O YA+Ao1XRKGj9A6aeOG+5CmA1yBD1Iq2oV+Nx+Na/f97mmbMiTtKPmWLdZ0EQo44Y9D4QVrIGPc nSSmNVdTWLc7LGENE7bBfUeq
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Aug 24, 2021 at 04:23:22PM +0100, Julien Grall wrote:
> Hi Anthony,
> 
> On 24/08/2021 16:00, Anthony PERARD wrote:
> >      Changes to XEN_LDFLAGS may or may not apply to targets in for
> >      example "common/" depending on whether one runs `make` or `make
> >      common/`.
> > 
> >      But arch.mk is loaded before doing any build, so changes to LDFLAGS
> >      there mean that the value of XEN_LDFLAGS won't depends on the
> >      initial target.
> 
> An explanation in the commit message would be useful. This one you provided
> looks good. So:
> 
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Can it be merged before the previous patch? If so, I can update the commit
> message and commit it.

Yes, that should be fine, thanks!

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.