[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/9] gnttab: drop a redundant expression from gnttab_release_mappings()


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 26 Aug 2021 12:11:51 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9pIz493n8vP2lByOzJVJJbPpIRS7dNzvxod2n9ZIyps=; b=lYGQaCvgtPpTCZnky5Lrzg1a/HQfCZNrbmA33m/BaTsjz3WojLs/q9HbYp1lDljmsLaRnsLEzshub3eJ/V9bTCdubpsIshU+JPCYiKHuI5GhMMORTYoK7/HZsgzZCD28mZ8Qq4/uGyaCkTWJnh3yABHRhcS9tX0kmZtRj6zwKH/En3ZQ9CT3N/Z7c5RFAn/fr5P41A+UOLyPGoF0VAijBAGjZLCJh98z7HgtU8eZVEsO93suZXbBdO5vkm48fOh5Dy4NQ+A7i61RryVJ1iSq7HNewF2B41+DYBbN5hDGc6WtlAuDmY7GYpxwR1gCfLY5k/OoTNCUiUm5qslrRscutg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WbY4FW7gDW2bvo4M9kY60wbM9Kr6Gst4sq+Nb8yMgNdw1Zysf64C49mPSYe2B9XtIWaqVYs8661HPhWOnanDczZw2qve7L8TVGpyDtGaosBFGX9/4PiWuNIdaO0RC1gN9B8iKERrQJxhasOky0Ed3eVpHFzkvJtemDoP0hhlS7t7Qe0ugTdFED6hpJ5vve8yUkOZnrEZBe/O23ee4MhKoVrkgxDGj/zo2bqJUfbGSDp+MehQPISRHuDyW64dkoQrFhESLdMh+O7brQKioX0Tvwz4Jn6IPfJitpqPybS7bkVWd4hGBBZBUzSJ5Gj7+GbS3AVHFjr9D/pzhSxJYzu3+w==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 26 Aug 2021 10:12:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

This gnttab_host_mapping_get_page_type() invocation sits in the "else"
path of a conditional controlled by "map->flags & GNTMAP_readonly".

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -3816,9 +3816,7 @@ int gnttab_release_mappings(struct domai
                 if ( gnttab_release_host_mappings(d) &&
                      !is_iomem_page(act->mfn) )
                 {
-                    if ( gnttab_host_mapping_get_page_type((map->flags &
-                                                            GNTMAP_readonly),
-                                                           d, rd) )
+                    if ( gnttab_host_mapping_get_page_type(false, d, rd) )
                         put_page_type(pg);
                     put_page(pg);
                 }




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.