[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN RFC PATCH 34/40] xen: move numa_scan_nodes from x86 to common

Hi Wei,

On 11/08/2021 11:24, Wei Chen wrote:
diff --git a/xen/include/asm-x86/acpi.h b/xen/include/asm-x86/acpi.h
index 33b71dfb3b..2140461ff3 100644
--- a/xen/include/asm-x86/acpi.h
+++ b/xen/include/asm-x86/acpi.h
@@ -101,9 +101,6 @@ extern unsigned long acpi_wakeup_address;
#define ARCH_HAS_POWER_INIT 1 -extern s8 acpi_numa;
-extern int numa_scan_nodes(u64 start, u64 end);
  extern struct acpi_sleep_info acpi_sinfo;
  #define acpi_video_flags bootsym(video_flags)
  struct xenpf_enter_acpi_sleep;
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 490381bd13..b9b5d1ad88 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -81,8 +81,10 @@ extern void bad_srat(void);
  extern void numa_init_array(void);
  extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn);
  extern void numa_set_node(int cpu, nodeid_t node);
+extern int numa_scan_nodes(u64 start, u64 end);

AFAICT, by the end of the series, the function is only called by the common code. So this should be static.


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.