[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [XEN RFC PATCH 38/40] xen/arm: enable device tree based NUMA in system init
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Sat, 28 Aug 2021 03:17:43 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gRx1UnI2+7Q1lBsKrHCTnH+9Ao7bcFD9TInqTL3yG4=; b=Q00lz8bNq/0f2tgxjsys8na0z1msjJT80bOkqMRv4k13KquLoh4UjT6Jxd4TVJBOzqYsVnvkdjv/B79DT1zLghl2h0kVusgyDy3P3Lg5BsKowlpvJ8SQV7cAQW1oWD2xRLh0Inm12iYP2AzuCJLYgLURRlRL885gR22h1xf790jSWYgXS2R154kLHOLA54OXp9uAUU7HgXk/Mr+pjxIl3gzS0zvT6cSTG/LX1gzv37FxkItNzm3qG7arDS/QQmzS2uidl3oe1JnEogB3CiFlOLxxTdUFLq7uG1DfjnAoVmE27seUkI/F0dCR/4QeoWsEAurDrFt6xChoSma5nvG40g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c260Y9urKjJtkZ4U2ZmLw7D9nsDMtR2rNv2jMXRjBiNgz+4T+QA2PlmQxqDM2TBexafXIRpP4ixxMZDQRJyYlt6FC8xv0jbzkuhYamalNReMJ3TEjHcuwRxsmnMnt4dsHr2cwkVyQoKaIhXxh3brkurZkdExNtQ+VESXZquPuA3kap6+P7uAfmFjE0Rk5cJyAX+ASO0r9+kFiFbubZKSMbToBrV7AOKKCQppYIh8M/qbMw5QMwKFiuIVwOedwn1J9gRZFnMRiS14Wfp/NO74DvW+5Nu6Yo4ty83sLD0XofnhQftfyAN7oXo8eALdRLCR59QoMhNCF0d6R0AwW2358g==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Sat, 28 Aug 2021 03:18:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXjptQCVAwokAljU6uEdAOvxt6uKuHg4WAgADUAaA=
- Thread-topic: [XEN RFC PATCH 38/40] xen/arm: enable device tree based NUMA in system init
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: 2021年8月27日 22:33
> To: Wei Chen <Wei.Chen@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> sstabellini@xxxxxxxxxx; jbeulich@xxxxxxxx
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Subject: Re: [XEN RFC PATCH 38/40] xen/arm: enable device tree based NUMA
> in system init
>
> Hi Wei,
>
> On 11/08/2021 11:24, Wei Chen wrote:
> > Everything is ready, we can remove the fake NUMA node and
> > depends on device tree to create NUMA system.
>
> So you just added code a few patches before that are now completely
> rewritten. Can you please re-order this series so it doesn't happen?
>
> This may mean that CONFIG_NUMA is only selected until late in this series.
>
Why I did like this is because my original concerns are:
1. When I introduced the CONFIG_NUMA. Users will be using a code base on
this commit by accident.
2. If users select CONFIG_NUMA, but not all NUMA data are not initialized
properly. The system may not work properly.
3. So I created the fake node to initialize the NUMA data, before we parser
real data from DTB.
4. In this case, user can work well with CONFIG_NUMA is enabled, without
this series is completed.
It seems I thought too much. If these concerns are not necessary. I am
OK to re-order this series.
> Cheers,
>
> --
> Julien Grall
|
