[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 03/30] hw/core: Un-inline cpu_has_work()
- To: qemu-devel@xxxxxxxxxx
- From: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
- Date: Thu, 2 Sep 2021 18:15:16 +0200
- Cc: Bin Meng <bin.meng@xxxxxxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Greg Kurz <groug@xxxxxxxx>, haxm-team@xxxxxxxxx, Kamil Rytarowski <kamil@xxxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Anthony Perard <anthony.perard@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Michael Rolnik <mrolnik@xxxxxxxxx>, qemu-riscv@xxxxxxxxxx, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Chris Wulff <crwulff@xxxxxxxxx>, Laurent Vivier <lvivier@xxxxxxxxxx>, Cameron Esfahani <dirty@xxxxxxxxx>, Sunil Muthuswamy <sunilmut@xxxxxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Taylor Simpson <tsimpson@xxxxxxxxxxx>, qemu-s390x@xxxxxxxxxx, Richard Henderson <richard.henderson@xxxxxxxxxx>, Bastian Koppelmann <kbastian@xxxxxxxxxxxxxxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, Roman Bolshakov <r.bolshakov@xxxxxxxxx>, Laurent Vivier <laurent@xxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Wenchao Wang <wenchao.wang@xxxxxxxxx>, Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Marek Vasut <marex@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Aleksandar Rikalo <aleksandar.rikalo@xxxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, Colin Xu <colin.xu@xxxxxxxxx>, Claudio Fontana <cfontana@xxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, Reinoud Zandijk <reinoud@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx
- Delivery-date: Thu, 02 Sep 2021 16:16:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
We want to make cpu_has_work() per-accelerator. Only declare its
prototype and move its definition to softmmu/cpus.c.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
---
include/hw/core/cpu.h | 8 +-------
softmmu/cpus.c | 8 ++++++++
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index 2bd563e221f..e2dd171a13f 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -546,13 +546,7 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags);
*
* Returns: %true if the CPU has work, %false otherwise.
*/
-static inline bool cpu_has_work(CPUState *cpu)
-{
- CPUClass *cc = CPU_GET_CLASS(cpu);
-
- g_assert(cc->has_work);
- return cc->has_work(cpu);
-}
+bool cpu_has_work(CPUState *cpu);
/**
* cpu_get_phys_page_attrs_debug:
diff --git a/softmmu/cpus.c b/softmmu/cpus.c
index 071085f840b..7e2cb2c571b 100644
--- a/softmmu/cpus.c
+++ b/softmmu/cpus.c
@@ -251,6 +251,14 @@ void cpu_interrupt(CPUState *cpu, int mask)
}
}
+bool cpu_has_work(CPUState *cpu)
+{
+ CPUClass *cc = CPU_GET_CLASS(cpu);
+
+ g_assert(cc->has_work);
+ return cc->has_work(cpu);
+}
+
static int do_vm_stop(RunState state, bool send_stop)
{
int ret = 0;
--
2.31.1
|