[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/11] libxl: Only map legacy PCI IRQs if they are supported


  • To: Juergen Gross <jgross@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Fri, 3 Sep 2021 10:30:59 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=I1JrNBXFqVlvMtY1Qn3q/f0qiRWmgN9ym+/sXuGPkl8=; b=FQRcp0uWYrbOpcOdTD8BrEIn1Fbh4GoQKVerphzb1pk6uU/wMz99+ELzJENI1WRXB45lqWy27STwo6HBqieNRdmsVYc2tMZOl9SfNYfVFxuMBL29KKYDAZWMluWufCDZ9BzSLOYx8DStaYp+YBz/e0GiBv6sqQhMx4ww6eMVqwII3vXj8rCD+MhEfmDmJyIZ5Hn27XLJQmVk/kEmm/xvhnHVoHhssP3qjPdAr0rt3aNr87kWIXKTQ99nxwWPduu80uW6GTxELnx7WTWq3Yo4diPyxZkh/eZT/1ijNoN41bV2nFfDWoWjHI5TqsTR+DXvSAtALx/IR/gnwwnZno9gig==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=co8f4AWKsRTST6P4ipuy/UNZ0+L9aX9mgokwvNy1uK9hBCyb+xBuVoqEjpSWeIULAsbASidG+1nQfqA4nm1rQrFEUk8OmEsdgv7sb+O4rgQrJsqJ9o0R8TsA8CWW8AO+hKzj+FRbac14jsitnV1OsQlI3pgOQWvJ0fCH18+PKCbxT6ncDjNtRzt5OTtYcX07M/vdhiEVhZXx77j/WXLb6c9Y0LX22OSuWWzOAuPNnok/Js0Cqe0xu7uHlfM+Rc0810vHVphnBOT6wMr2io/di5plrrG5PU+pbGeteKf4f1f2G5lG1MAuLjAhte5ju5nM5poDfox1c7Sw67db1avQkQ==
  • Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
  • Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Fri, 03 Sep 2021 10:31:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXoJ50aOdU36kT/0mQrZPJ6sbBAauSGzCAgAABJYA=
  • Thread-topic: [PATCH 08/11] libxl: Only map legacy PCI IRQs if they are supported

Hello, Juergen!

On 03.09.21 13:26, Juergen Gross wrote:
> On 03.09.21 10:33, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>
>> Arm's PCI passthrough implementation doesn't support legacy interrupts,
>> but MSI/MSI-X. This can be the case for other platforms too.
>> For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
>> it to the CFLAGS and compile the relevant code in the toolstack only if
>> applicable.
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>> Cc: Juergen Gross <jgross@xxxxxxxx>
>> ---
>>   tools/libs/light/Makefile    |  4 ++++
>>   tools/libs/light/libxl_pci.c | 13 +++++++++++++
>>   2 files changed, 17 insertions(+)
>>
>> diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
>> index 7d8c51d49242..bd3f6be2a183 100644
>> --- a/tools/libs/light/Makefile
>> +++ b/tools/libs/light/Makefile
>> @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
>>       -Wno-declaration-after-statement -Wformat-nonliteral
>>   CFLAGS += -I.
>>   +ifeq ($(CONFIG_X86),y)
>> +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
>> +endif
>> +
>>   SRCS-$(CONFIG_X86) += libxl_cpuid.c
>>   SRCS-$(CONFIG_X86) += libxl_x86.c
>>   SRCS-$(CONFIG_X86) += libxl_psr.c
>> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
>> index 59f3686fc85e..cd4fea46c3f7 100644
>> --- a/tools/libs/light/libxl_pci.c
>> +++ b/tools/libs/light/libxl_pci.c
>> @@ -1434,6 +1434,7 @@ static void pci_add_dm_done(libxl__egc *egc,
>>           }
>>       }
>>       fclose(f);
>> +#ifndef CONFIG_PCI_SUPP_LEGACY_IRQ
>
> Why #ifndef? Shouldn't this be #ifdef (same below multiple times)?

Yes, you are right. I have to revert the logic, e.g. s/ifndef/ifdef

Other than that, are you ok with CONFIG_PCI_SUPP_LEGACY_IRQ name?

Thank you and sorry for the noise,

Oleksandr

>
>
> Juergen

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.