[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/11] xen/arm: Mark device as PCI while creating one
- To: Jan Beulich <jbeulich@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Fri, 3 Sep 2021 13:26:00 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6rcs18nY5JhoWpG4h295efE9YtJvCF4tu+ICLvI9ne4=; b=Zg1lrU1sJVm30bzA/GuYNC9PKopgFumn/Fx+rN0/sUd3fBVJEPDsvaFm/FE0cy/N8m7yL3Tmr5evelVc4EPvygDUoZeIm/e8rWYVsmQw/LrEV2zREK7cMPSiBPwiRFs+ItnUmJyOaajiEaNfjydOZAx7LYUDHFs7GNOr/1gAKjI7kQgnqR/4p+2yr6mXuW7PgvFif2p6/GgG/D5I1/lrl/984omQUhmSRVZlXLpBwUGgu5pD2gJqmlTspIS0g5wBNsoHqEZSm1Lb4sNbAQYyLdY6T1k5VSB1hBUHmdOQYSYsHnTLvecX2PvtfpFmKc0SFWWfYnoDnCmqNmQKfcwp6Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hj1sS21G0hxhYDsmoxMrwT9Qlg7scEdPifIVtS4F3i1kjyAgNjZaMfEkPZC98nywNJs5ZTNFsQ2LKnaRB7CeC366vj3wxXc7gLe4Nx3afpUKE8OWGDUHQtkLhCkz9JZI/P452D706ok2w1ABtQtNso+BWysdA2HsqpadlPPOnynj6JsiIup+0xEevir8wJDQCvBJTwW3fVtUYl+GfSdrc9dGstZGFjzhYXJKFS7Rj/dUocg8N7bN5/t/4XpWAt+Q0te/cbMQj6ByPQinaTaSUVAifRHoJ6wo5wo+WFw5LVprUEYqJzv8pAUNORGpdQYVlLrFqxZzVWfm3FlQiYxY/g==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 03 Sep 2021 13:26:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXoJ5xoGQK6kA9E0qeGYyDKoX2LquSQMSAgAAMdoA=
- Thread-topic: [PATCH 05/11] xen/arm: Mark device as PCI while creating one
On 03.09.21 15:41, Jan Beulich wrote:
> On 03.09.2021 10:33, Oleksandr Andrushchenko wrote:
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -1301,6 +1301,9 @@ static int iommu_add_device(struct pci_dev *pdev)
>> if ( !is_iommu_enabled(pdev->domain) )
>> return 0;
>>
>> +#ifdef CONFIG_ARM
>> + pci_to_dev(pdev)->type = DEV_PCI;
>> +#endif
> Why here instead of in alloc_pdev()? The field should be valid by the time
> the new item gets inserted into the segment's list of devices, imo.
Yes, makes sense.
Thank you,
Oleksandr
>
> Jan
>
|
