[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 01/30] accel/tcg: Restrict cpu_handle_halt() to sysemu

On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
  static inline bool cpu_handle_halt(CPUState *cpu)

Hmm, slightly better to move the ifdef just inside here,

@@ -607,6 +608,7 @@ static inline bool cpu_handle_halt(CPUState *cpu)

and here,

      return false;
+#endif /* !CONFIG_USER_ONLY */
static inline void cpu_handle_debug_exception(CPUState *cpu)
@@ -865,9 +867,11 @@ int cpu_exec(CPUState *cpu)
      /* replay_interrupt may need current_cpu */
      current_cpu = cpu;
      if (cpu_handle_halt(cpu)) {
          return EXCP_HALTED;

which would eliminate this one.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.