[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/9] gnttab: fold recurring is_iomem_page()
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 6 Sep 2021 16:02:06 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cKa39fBdUuKKjVZJgUwDa3lk0XUVFaHOI2TGt9dFD3s=; b=U0FhI7l3QY6+6kb7R8iCDS4voC/A/nkRC/GyVuCOxQp/j7np6B5piRyZ7pZaD9SmnNJPTBEdw0KT/xOh74I75mMvMGbxinWQoP3tDeRQcekSONcetQq4rWQHwJNjH2aRpxi1INUWYMFoVhPKcyYFsG9SJDMFGCaHzWsIqkkQgTktqnrQr765jtC4S2gwgt9ATb5Wnuqexz8npeddnUKFDRijcGqZ1ZIWy+GX7FTpdtzYdfSn8nwSx48wv3H5hZSStcrIAth8w87Lz5nfXJRn9nAvHlMxV/nq36QOtik0A6cuEUPoAePLwYGMDnNNfuqtCIKqOjbZwYUTLmlEIURxCA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nBbCop4iwZ/1vJQhPYwnF0RG0nIBJNsg+txUdd9x4e6zVBL6fCgspB9H6NgnFDmYmFQUhKy4CalZLwo3ZmTC7WbE2N1g9e/+tpi8wQLSCMIfb4F1g9CezJCozlIH1zxblftsIKAi4rTBanZhOCTjoqz6h/bkDjithrqfWKWFeC+0Te4NHV4LnDJT9dgAiM0RkAPBbv6itR4MYBYM/z4tOUjYKT6B6vHeuy0YZCPhtPBZghRHw/wQWlWvng8upywK7g79AyUP+hfwtRM9Fsf1Tae8LxluumwgRvi7/+KtK0Wu3OU7QhW89r2RwBfjCaORy9+vNjN/byZnDh2wgTPZOQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 06 Sep 2021 14:02:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.09.2021 15:35, Julien Grall wrote:
> On 26/08/2021 11:12, Jan Beulich wrote:
>> In all cases call the function just once instead of up to four times, at
>
> extra NIT: It is more like two because there is a else in
> gnttab_release_mappings() :)
Well, I was viewing things from code gen pov, not so much execution
paths. And of course "two" is not wrongly covered by "up to four" ;-)
>> the same time avoiding to store a dangling pointer in a local variable.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks.
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
>
> [...]
>
> Everything below looks a duplicate. Might be an issue in your tools?
Oops, indeed - some kind of glitch. Odd.
Jan
|
