[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/9] vpci/header: Handle p2m range sets per BAR


  • To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 6 Sep 2021 16:47:46 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AwH30p3wBzytY59LExMHtIgmcTmt2MaZkmO+Zyddd+c=; b=WirNdtYCR68ybkJpUYfjzFTRXSYMd29JPEu5R9tki/RxVVLJSLHmEhlP73I5NI/8ciX3HI4T5LnidemDPT0lU8Zats97XMdLBI+GKseJOjNNg/JL4cR9y74VBi9zZ3GiamfpIEIi3YIrQPCaXx4MJSFkAX3W3psU4vq1gQFB8+Z5RJOl90J2KtndwsVa84gLvIo14t8bYLQPgC+y7inVr1nbkN0eZCm0FCS1qeZ6Mvt6FtqIhf/FndZVlerMcPZzQLTEionSWciiaC6Yi6a/EzeXQOsMHxup4Q/yapY1ZHanmRUq2yOUpsSYYlVyIWhJuRPsqwoImefsrypTsY6M+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OTfbOVi/et79nELYmQ8BNq5hkBRpCAPpse63+n3f45zLQcO1I8bXM/5C/tzpVawm+6ukcu+FIf0Jc3ix63zkfJDN3UJFSAq9xqsyY/Je2wmkaMzP4pk3aay0x8Y8hYRZOFwrNhfospa9wXWGK+tWUYX/pMhQfYHnQSxfxgc+W1wl/BrNGx/NqXjz2f21B24M+6g68TT64MjV2ls55u+lPGicIwETsMkPznfGKprZs7y2XKThPwamZSvx6TknHxSKXYL59PSKhFSixdjV/VaITlayAzak/SfWeV8Xuu4eYrwVPlV2ahX9eG1XCFLZh/E5fC8CH2gvW73y+t5tClTy9A==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: julien@xxxxxxx, sstabellini@xxxxxxxxxx, oleksandr_tyshchenko@xxxxxxxx, volodymyr_babchuk@xxxxxxxx, Artem_Mygaiev@xxxxxxxx, roger.pau@xxxxxxxxxx, bertrand.marquis@xxxxxxx, rahul.singh@xxxxxxx, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 06 Sep 2021 14:47:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.09.2021 12:08, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> 
> Instead of handling a single range set, that contains all the memory
> regions of all the BARs and ROM, have them per BAR.

Without looking at how you carry out this change - this look wrong (as
in: wasteful) to me. Despite ...

> This is in preparation of making non-identity mappings in p2m for the
> MMIOs/ROM.

... the need for this, every individual BAR is still contiguous in both
host and guest address spaces, so can be represented as a single
(start,end) tuple (or a pair thereof, to account for both host and guest
values). No need to use a rangeset for this.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.