[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 02/14] xen/pci: solve compilation error on ARM with HAS_PCI enabled



Hi,

On 19/08/2021 13:02, Rahul Singh wrote:
Compilation error is observed when HAS_PCI is enabled for ARM
architecture.

Add definition for arch_iommu_use_permitted() and
arch_pci_clean_pirqs().Implement dummy functions for pci_conf_read*() to
fix compilation error.

pci.c: In function ‘deassign_device’:
pci.c:849:49: error: implicit declaration of function ‘pci_to_dev’;
did you mean ‘dt_to_dev’? [-Werror=implicit-function-declaration]
             pci_to_dev(pdev));

pci.c:18: undefined reference to `pci_conf_read16’
pci.c:880: undefined reference to `arch_pci_clean_pirqs’
pci.c:1392: undefined reference to `arch_iommu_use_permitted'

Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
---
  xen/arch/arm/Makefile               |  1 +
  xen/arch/arm/pci/Makefile           |  2 +
  xen/arch/arm/pci/pci-access.c       | 61 +++++++++++++++++++++++++++++
  xen/arch/arm/pci/pci.c              | 32 +++++++++++++++
  xen/drivers/passthrough/arm/iommu.c |  5 +++
  xen/include/asm-arm/pci.h           | 33 ++++++++++++++--
  6 files changed, 131 insertions(+), 3 deletions(-)
  create mode 100644 xen/arch/arm/pci/Makefile
  create mode 100644 xen/arch/arm/pci/pci-access.c
  create mode 100644 xen/arch/arm/pci/pci.c

diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 3d3b97b5b4..0e14a5e5c8 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -6,6 +6,7 @@ ifneq ($(CONFIG_NO_PLAT),y)
  obj-y += platforms/
  endif
  obj-$(CONFIG_TEE) += tee/
+obj-$(CONFIG_HAS_PCI) += pci/

This should go before platforms/ to keep the order alphabetically.


Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.