[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 09/11] silo: remove circular xsm hook call

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Thu, 9 Sep 2021 15:14:36 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631214880; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ODeFCicDvawAcTinn7/rak3JqgqM+ZCyMPqIlQYJDjY=; b=hkKtfQXbJwjMKm6df8JMTr04vGm+nAKXnwRSXIIj/lfam5hkWoGgj8tMLjZXXaG7x9rvTLz9S86acNN/9/p9199jnCRADghNXxE+b1uzxq8w5YdPlDRdrZorHi8q8a3ugTpgBTlKeBWMOEiIncCcQWpJkrRhAIvdJcMTLAFLApo=
  • Arc-seal: i=1; a=rsa-sha256; t=1631214880; cv=none; d=zohomail.com; s=zohoarc; b=j3L5o5aeeznB4XNecWft0aEDbtDi1ivmqKg28WFHnrepXkKlnTXP5pFhYlOpCahd/8tR32XkK/TDTHzFtqW4jBArczQvmhWXIpAA1Bv/EoOyA4cM+Lw7bOddkCJu5uyOKJ+FIa6YCEChn2cmNFjcWkNkRGovDghpkR0ZjbXfQnA=
  • Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 09 Sep 2021 19:14:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 9/9/21 11:45 AM, Jan Beulich wrote:
> On 03.09.2021 21:06, Daniel P. Smith wrote:
>> SILO implements a few XSM hooks to extended the decision logic beyond
>> what is defined in the dummy/default policy. For each of the hooks, it
>> falls back to the dummy/default policy. The fall back is done a slight
>> round-about way. This commit makes the direct call to the default policy's
>> logic, xsm_default_action().
> Again it's not clear to me what you're finding wrong here. The way it's
> done is not as direct as it could be, but going through the extra layer
> allows the functions to document things at the same time. You lose not
> only that documentation, but also ...

It is only for six calls, thus I figured the slight overhead would be
worth cutting out the indirection. If now one is worried about the extra
indirection, than I can adjust to call the default's handlers.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.