[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 03/14] xen/pci: solve compilation error on ARM with ACPI && HAS_PCI

  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Fri, 10 Sep 2021 10:22:36 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0IH2HzNoNfuCeV/9Zst8NrF5laXRyY0kXLZMgIrX9IQ=; b=PseFCo/tp8n89tNyGC1fIR/19NKoywAkMYUmsE3S2MiO0MgyzOIYJIFl1N8s4YBsv/y8LfYr0t7tnUWRk53bMlB1V92yGPTRiy50A9T5rYUw4AX9/7DdbFwsB8f4Bv5653Pkj7AVsy2L3l908I/plrQQO+6auV4JvRf27bAmT7nubMufgjQOfctyD3BSKogzH4fw07MUngj1hY03vqSQb4BqU13bGbmbDkfPU52K7lETyiAnVhZ8Con6HBX2R7aFJRe/EfgZZWC9K7ShI/B9TbbgCOzDCAM+EQ2xzXhN6PbuIUI/9epfBO5s1NFEk1HyF5Uy+3xJxh7AGJJdeykq/Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lp292GZZnetE+LimbD9HvWHr/eAIEx5moK+JG4tT+mmChNGLf0TFD7P/YrSaTpF6Ajg3qB3EiJZxbCdjda7N3Z5w073uT40juOcfNeofXHQwH5aA6Tojzh2lZB+ckMLojPXZEZ7j3RtNcub1Dylyf+7etlGvJVMS+s7YI86YzQd6PJrkzX3mxbb0pYjg9v0uZz9JWlurbgXsHnAYL9hfxtT+ZppTwu2zOD5OIpH0q9Xa86ekcDymQG56miQo+Iu+WSeKFVk4tvIle7u5pPzMxZDy/DtZSZOe26girHUM8R4WwjBas/kWfsbHFh618dlIC98AuZgmYiETy88kyFv9mA==
  • Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 10 Sep 2021 10:22:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXlPKNppsGoVMjlkS0HQqYv0RYK6t7+ecAgABMtoCAAAOrgIAeuwQAgAIsWAA=
  • Thread-topic: [PATCH v1 03/14] xen/pci: solve compilation error on ARM with ACPI && HAS_PCI

Hi Stefano,

> On 9 Sep 2021, at 2:11 am, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> On Fri, 20 Aug 2021, Jan Beulich wrote:
>> On 20.08.2021 13:41, Rahul Singh wrote:
>>> Hi Jan
>>>> On 20 Aug 2021, at 8:06 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>> On 19.08.2021 14:02, Rahul Singh wrote:
>>>>> Compilation error is observed when ACPI and HAS_PCI is enabled for ARM
>>>>> architecture. Move the code under CONFIG_X86 flag to gate the code for
>>>>> ARM.
>>>> Please give at least one example of what it is that fails to compile.
>>>> What an appropriate action is depends on the nature of the error(s),
>>>> and from looking at the enclosed code I cannot easily see what it
>>>> might be that breaks for Arm.
>>> I am observing below error when enabled ACPI && HAS_PCI for ARM.
>>> prelink.o: In function `pcie_aer_get_firmware_first’:
>>> /xen/drivers/passthrough/pci.c:1251: undefined reference to 
>>> `apei_hest_parse'
>>> aarch64-linux-gnu-ld: 
>>> /home/rahsin01/work/xen/pci-passthrough-upstream/xen/xen/.xen-syms.0: 
>>> hidden symbol `apei_hest_parse' isn't defined
>>> I found that apei/ is only enabled for x86 and 
>>> pcie_aer_get_firmware_first() is only called from x86 code.
>>> obj-$(CONFIG_X86) += apei/
>>> I am not sure whether we need this code for ARM architecture 
>>> that is why I gate the code for ARM via CONFIG_X86
>> So you Arm folks will probably want to settle on that aspect first. What
>> is wanted to keep things building depends on that.
> Reading the APEI description, it looks like there might be some use for
> it on ARM but it would work a bit differently from x86 as there are no
> NMIs on ARM. So enabling APEI on ARM is not just a matter of enabling
> the build of apei/, it is not going to be straightforward.
> For the scope of this series (which is actually about PCI), I would
> leave it alone, and keep apei/ x86 only, which means #ifdefing
> pcie_aer_get_firmware_first.
> I would just add an in-code comment saying "APEI not supported on ARM
> yet”.
Ok. I will add the comment in next version.

> Another option would be to introduce a symbol like HAS_ACPI_APEI
> but it is a bit overkill for this.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.