[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 08/14] xen:arm: Implement pci access functions
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 15 Sep 2021 10:47:53 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zQetbcv3diWg4Fav5cK9sH+6bAAy1ZfmP9iOA6LOBeU=; b=k0r3uy7SP+Lfll6HUoHcZ8WR5nvtyumZgf+bu2NTuPF9JlKj8UorNklTQR/CuHMUO4OhlfklUFUNpFx3NGDI3OOAr3SC6CUtckXBOmumI1sHo964GqTTuu/oFre8eTsWCoL34OmNOB+xNaUNaJVWQKnlKZj1a/zobb6Wx/ADujSAnGhdai5IlhXcwVeOa0t6wxYlCEpeVhaDoDVTp5nePM/dgd/dsah9YoUTO3Q/xc/tm/YmsSW+oD+ixTXcX7BN8h14+rq1A6ruGmbq4XMhTbOkl18B+ZSCXBEW87EItv/5Bhc2rGp0UuJ9iMJquVKxWzfI9LF9h1TZzBpoXrFnmA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dF4phKe/BdpqZAFtwMSsajXg8Tik0ohllPLPpjSDuvArY5uNAq4aW9MrbGgknhym+f+9vpSMaxcF1lQRyPCKGL2X+N9twSOIkLoameM3oZlYNo56yOPxIMnMhNugAun0zOUzPXkJMISdxZR6dlmLKz4Elz51pDxubpv0TbtNCifdFUstlNjjBulXMt6tY0vy9n7c/ZQCs6sROZZ0H3pMJxM3cL2n1l6flOeETeAnsyN6TEMfJewG0qiCoTw0CDqub3rZy9jN/SFxdplu8V23OmyJKa1RT3mcCrBqZkae1UIZvpUkf1O/kGmmwvJgQbHTRHC4ea/byH+SvfPtHgNDHw==
- Authentication-results-original: epam.com; dkim=none (message not signed) header.d=none;epam.com; dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 15 Sep 2021 10:48:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: epam.com; dkim=none (message not signed) header.d=none;epam.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXlPLKFxZ9ODgqA0ysGgNkOt1JX6ucfp8AgAdcI4CAAQksAIAAMHGA
- Thread-topic: [PATCH v1 08/14] xen:arm: Implement pci access functions
Hi Oleksandr,
> On 15 Sep 2021, at 8:54 am, Oleksandr Andrushchenko
> <Oleksandr_Andrushchenko@xxxxxxxx> wrote:
>
> Hi, Rahul!
>>>> static void pci_config_write(pci_sbdf_t sbdf, unsigned int reg,
>>>> unsigned int len, uint32_t val)
>>>> {
>>>> + struct pci_host_bridge *bridge = pci_find_host_bridge(sbdf.seg,
>>>> sbdf.bus);
>>>> +
>>>> + if ( unlikely(!bridge) )
>>>> + {
>>>> + printk(XENLOG_ERR "Unable to find bridge for "PRI_pci"\n",
>>>> + sbdf.seg, sbdf.bus, sbdf.dev, sbdf.fn);
>>> same here
>> Yes I am printing with “PRI_pci".
>
> vPCI and the rest are widely using
>
> printk("%pp\n", &sbdf);
> So, I think if we have SBDF then it is better to use %pp instead of trying to
> unfold it manually.
Ok. I will use the %pp for printing the SBDF.
Regards,
Rahul
|
