[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo
- To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 16 Sep 2021 16:49:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qsGwjLGjMd2sjdb1xjhyVcOKuQDtTDX1mMRtJDJN2l4=; b=bHTZw4xJOTgkBodUJo7mrVjOpMMLn/A4EmiQz0l9LsjtCHqqX/ui9QS0Aey/8Ej0JOkFvhiNESVcv8nAttU9ZC/xU867L+9YSznwrUkONsQ3MOnH2QSXwFvejGTMU24ngizPKOxFROL+8W/3GV+c25jqr4mcyAUYhFOt/Ke13XUsFqUL2y1kqjQkNnQyQsKRB7RrouBcuA9CmM33vAAQba99In5ozxAX1AhgwE/Tq/H50BdRRbIqqxSjGthPJRg10QuRQLJKGtaGsqj5vxmW6yHkVPYP35i3fUhNvwHujf6rU1CJSiZDTbvkmoZdFXW1o6wk8t4paJ6TrHbVMzkLOQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eEIpGdr7sBcDl3WYy9KvNODReUDPDf57P3VkDAcVWtQaTIlzFXEVesg94xOlRqXPofS9SFpIoKuSNkdUBt2o0XbV5B7lJmsJuDMjaDJLvA5t5BPITXtygViwbNi0mnTlkGPiTqM+sJeY92Gho5SW4ieIG+DPASRlAb/DDC+iGCzkxaQHNBot7CpAnxNwZ3Myuw//o22CkvMMoshIm1MoFSP1gt5nmPyDg72QTnCphQYp/FEChdh3o+ksH9KUzWpHkF9qHzomQul04+oThaB8Htxg3ulNXvfA6W76R54G4RxPA/PWtEfqL4UoQPMsj0mVATpYTqtszDQw79f7ddDoVA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 16 Sep 2021 14:49:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.09.2021 20:18, Oleksandr Tyshchenko wrote:
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -855,6 +855,13 @@ typedef struct libxl__ctx libxl_ctx;
> */
> #define LIBXL_HAVE_PHYSINFO_MAX_POSSIBLE_MFN 1
>
> + /*
> + * LIBXL_HAVE_PHYSINFO_GPADDR_BITS
> + *
> + * If this is defined, libxl_physinfo has a "gpaddr_bits" field.
> + */
> + #define LIBXL_HAVE_PHYSINFO_GPADDR_BITS 1
Nit: I don't think you mean to have leading blanks here?
> @@ -120,6 +120,7 @@ struct xen_sysctl_physinfo {
> uint64_aligned_t outstanding_pages;
> uint64_aligned_t max_mfn; /* Largest possible MFN on this host */
> uint32_t hw_cap[8];
> + uint32_t gpaddr_bits;
> };
Please make trailing padding explicit. I wonder whether this needs
to be a 32-bit field: I expect we would need a full new ABI by the
time we might reach 256 address bits. Otoh e.g. threads_per_core is
pretty certainly oversized as well ...
Jan
|
