[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] page-alloc: further adjust assign_page{,s}()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 17 Sep 2021 10:06:21 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IZgxB81np4TnDRupKJrs1tz6pX5AZNgDbrypJd0tpdI=; b=WquEaa5v/++1/G0PzAe1ugq2uSDHWRa8D5FSv3yqUCJ+6n94ehC8g5iFeE5L5c3aw0aIhjVZwUj9qE3ipFocwoPHBNMC5IHpQ45RirF5tSrwDC2b3crL3wQUe8QotfN8dLW5qxFYE7+AipdEZoVYFYJXdxGB4mec3NvabFWddf3ljL4D2eSwZ9ZsbueZy251ppueDnw6LuQFv075IDpLoSh2aiE649I3zxjEEXLGfLv+r7EJZ9QfOEW+L5c3RCtwFMV6cER0oPqrsVI7DS+GPgCmpwpl/xUB2ktZTiksDcHMcraHimApcHuKXzywf7dHcAF215zgypYAoNjLK+oUWg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BnLO3iWIt2iBNCmR90L9f7xCk7xKzBPSMk4+cTplwtKKjUY2v/CtSqtuUYVPT1Kn8m6vpGtOYH3bzTdIW1No1Djrv30DUkfRrGBYWS0c1Tcg9TA/I33fzOn0lnbAkS/I8jCFgnEdcDWauluKmW6Z1zmg5fa8iYFuKd+CFnGYJcFA+RkwxAxcKI/+hoWuF64rGTCCY+chZVOY9QJoRaxRBi2ir77r+n+dJ6EJjgYwh5k5PRDxIBcTIYEvXBQP2kVpspOc5VL04aoD3fGJmL1hY8e6L0y+gLFQ1B6wibhN4vrw5i3bCIKFdSLIm2oZV8EgP79+VAunySKH4NhfGKqVqA==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 17 Sep 2021 10:07:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXq6qu/1IFuhFez06uzu67oLNGcaun//6A
- Thread-topic: [PATCH] page-alloc: further adjust assign_page{,s}()
Hi Jan,
> On 17 Sep 2021, at 10:58, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> The on-commit editing of 5260e8fb93f0 ("xen: re-define assign_pages and
> introduce a new function assign_page") didn't go quite far enough: A
> local variable and a function argument also would have wanted adjusting.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
>
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -2269,7 +2269,7 @@ int assign_pages(
> unsigned int memflags)
> {
> int rc = 0;
> - unsigned long i;
> + unsigned int i;
>
> spin_lock(&d->page_alloc_lock);
>
> @@ -2339,7 +2339,7 @@ int assign_pages(
> int assign_page(struct page_info *pg, unsigned int order, struct domain *d,
> unsigned int memflags)
> {
> - return assign_pages(pg, 1UL << order, d, memflags);
> + return assign_pages(pg, 1U << order, d, memflags);
> }
>
> struct page_info *alloc_domheap_pages(
>
>
|
