[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 2/4] PCI: only build xen-pcifront in PV-enabled environments


  • To: "bhelgaas@xxxxxxxxxx" <bhelgaas@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 17 Sep 2021 12:48:03 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jXZiYU8mKeQlBechJ1DkPrS64flo7XmAmn4tzLrzntA=; b=j/nqEUCa7GJUd+0T1JKPTVMyal9G/iXU+pugQMt96dxm0SoemHhwFG5AGbnd/M5s5DKyee3+hD7YkFg2G06bC55E2q5awNYg+tz2fcMbDnXhzUH0BjB9D+4MjsVrNyGyld6Du/7SwMcTgbJBLa9D36X+iNQiMyDbtuU6WRlqS5PoENKS7NWMTyXJmqkXqhAmBrMI2iMCj7nU4hX7qmXcFVZFigXE1zD/Ppot0oJkVGy2ZwrBpcf+qTlLlF90cLni59PfnDsff8P1cpKmREtce8m3YLfP5NcLo+8NpUQ8Uvg6BKYxwrEdQn+Pb2b42oSyp3Yip0RTiouLk8DeHfv+ng==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=adtmQkJ1ULl8weYlXLfqUczdzyaPdyGdqyc3AA6q8JQynzvHLdATv0VrQCDvvdSE/b4++5KCtMwrPApM5odmvu9iGGOXKEoiWMunbhAMqZZVXZov2anky5GgFgYPrswuiH8/ON/VQUvWzh6QvPYzit41GScDYvql2IZ+wf8ZhwR/5PLVh+u35wwCWJwxZU8JXyr/mN4tSsRHhobOsaja+a9g2d8RGohew2O8WqabehqDkZ9aimQVsV/Nvgfcz5XmhtKjqGQJ0xmL7QkEhIDJJsrwhkHgD8Ob+6CGMXEoJUoshIJIfrLiBNKZg+zLYGQYQ/trN0ZD00mRjs7qXjOOXQ==
  • Authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "hch@xxxxxx" <hch@xxxxxx>, Konrad Wilk <konrad.wilk@xxxxxxxxxx>, "iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx" <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 17 Sep 2021 10:48:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The driver's module init function, pcifront_init(), invokes
xen_pv_domain() first thing. That construct produces constant "false"
when !CONFIG_XEN_PV. Hence there's no point building the driver in
non-PV configurations.

Drop the (now implicit and generally wrong) X86 dependency: At present,
XEN_PV con only be set when X86 is also enabled. In general an
architecture supporting Xen PV (and PCI) would want to have this driver
built.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
v2: Title and description redone.

--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -110,7 +110,7 @@ config PCI_PF_STUB
 
 config XEN_PCIDEV_FRONTEND
        tristate "Xen PCI Frontend"
-       depends on X86 && XEN
+       depends on XEN_PV
        select PCI_XEN
        select XEN_XENBUS_FRONTEND
        default y




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.