[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] xen/credit2: Remove tail padding from TRC_CSCHED2_* records
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 17 Sep 2021 15:10:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LghKfE4iKbQSz30plE0IC+HIWMwQiUkQ5z32wjJKUwk=; b=TBfS5CetIYaks+9NjvKN7lfBiwAM51u2bcL1XErNIel5k8n7sNJra6yVpheO9y9sJFZBNBwxVM3WlGS3/SbFsttjOxUziSFzmCZn5ZLxx+wttgD2oIsAXsZC0ywI290UNSR93YomweTNyyd0A91WLrb0eDG+aElcCW0bdWrYaBWfeHmPt8DZnRBiRCUDUYGx2wFXwLsuRqNPhuuHN3JV7Wj8r9olDj4NzmtEx4dgiYxM6Aov7VnVv8Nyqrad3SCa4PwsLiuVYt1goWmL+5eXrk5qhNsCuZ7XHwLx5Z9UQLlZr/2tRYbzzFkuXp0WFkSec01K6AzFoSuJ1f0BPWWksA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fOSvcZzm1ydMu/yr3p0KgpwKAXNKJe6vPWFTGvSLGBIooflk3rS9gUg/EMxOT8f6F5KK/LOmMXQHefNHOuK6sySvAr37VNDY46epdvhGCLkRyH+FNjomtoS3Y2FwlLZTUM6sJEeX4GcoeDwwQj8ocMYnRTSG0kJGlRpLdkkwh1nAb06qCz8eY0Wfb/4HFKYY+9nm1/CLQrjRLuC+7wO9b1aXP02VsEDt9oMiZpzMkYr3pe6bDlcXTCHEpscKctPkrzPokrr8+uCwmtTs5oj8cN2HrALI5/R1BtIAgSNNfzyg7+VYCVxsGLkS2BlpZdynxAmGOmA2yt+WntQN7/sWzw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 17 Sep 2021 13:11:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.09.2021 10:45, Andrew Cooper wrote:
> @@ -1336,13 +1338,16 @@ update_runq_load(const struct scheduler *ops,
> {
> struct {
> uint64_t rq_avgload, b_avgload;
> - unsigned rq_load:16, rq_id:8, shift:8;
> - } d;
> - d.rq_id = rqd->id;
> - d.rq_load = rqd->load;
> - d.rq_avgload = rqd->avgload;
> - d.b_avgload = rqd->b_avgload;
> - d.shift = P;
> + uint16_t rq_load; uint8_t rq_id, shift;
Split into two lines? Preferably with this adjustment
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
I'd like to note that the remaining uses of "unsigned int" or plain
"int" in some of the instances you don't touch assume
sizeof(int) == 32, while generally we assume only sizeof(int) >= 32.
This is one of the cases where fixed width types are imo mandatory
to use.
Jan
|
