[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/6] xen/trace: Minor code cleanup
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 20 Sep 2021 11:15:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VxRie8cOTZnfkAjp5xIlxvn2twoJsUwQCtRW9MmLH7I=; b=E0bojPRTyMEZnaN9VePzip4dJM1Toq3tb4CuFf4aXkqC6LdEIgKG+eyec50zSVJtR3rbKaJM7oB/xcnPrUIfjDPh8e4AsJK95eTLKLn7ncwAvrUVVnFAi9I8Ylbl00oCg1ogDvDq4Ry13PFkTDNfL/vH87W7hK6+GaGkkEFaLd7W8dx4FPRgO3/25cCIxfcvac+nWQ3366vg9OL96fqdl20ZDySFxPcopKzq2+XD9MLgguEUqcu4aA+Lrqnr73sUIVEenmj0NE8jQF2wZ5b+6dNl7lTTX6O8oqm0a3PXyIqNJmngiGnvIyORBnTsezzw/2jomkxwZvwSP/woBTKlug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y/+utKpuaDOaB9Mw+McKaI5p2gltbtk68AV2/9w1HPHSSn4iHqWRpDmnGGw7wMXs2UAmMj500pwI5QkF8VRGJazMXb+rej7LkOyqntWb/5J/cfb6/RCk21NBNnUwu8KPZmoTJuAR6no3Vr96GvxMeiJgf94KnxFxF3s0YLHTz792RjHvBhRu7GAnq5djUb3MclSbSPCAkxWDp5ZoGsWe/3teEU5q9tSgZgcfWMvGKVD91XYj7L2hSMdJAcbxVD1dVeHo3N0lH/3YZ8fhVTF7HUgc1NtMwYuWJzKk9hKc/v7tKJwAawTz3r2CJ830l2UqYk0L3HJCHolmrHq1sBLScQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 20 Sep 2021 09:15:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.09.2021 10:45, Andrew Cooper wrote:
> * Delete trailing whitespace
> * Replace an opencoded DIV_ROUND_UP()
> * Drop bogus smp_rmb() - spin_lock_irqsave() has full smp_mb() semantics.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Largely
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
One remark:
> @@ -717,9 +713,6 @@ void __trace_var(u32 event, bool_t cycles, unsigned int
> extra,
> if ( !cpumask_test_cpu(smp_processor_id(), &tb_cpu_mask) )
> return;
>
> - /* Read tb_init_done /before/ t_bufs. */
> - smp_rmb();
> -
> spin_lock_irqsave(&this_cpu(t_lock), flags);
>
> buf = this_cpu(t_bufs);
I wonder whether the comment wouldn't be helpful to move down here,
in of course a slightly edited form (going from /before/ to /after/).
Jan
|
