[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/6] tools/xenstored: use atexit to close interfaces


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 20 Sep 2021 12:53:34 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ea/QQyMu7ExwpRYNFalsAY59NvqeBjZYHdIQjejtLwU=; b=Fl/UzympctbNGmBKK2sjBk5pCgAQMAZ4XpZuZETMposdsMsQepgHp1hj9h6hM+8OySB2mvbwhalwAW5CqdWKyEwv+ga4yKCofrTurSYT1VWvooz7fZODT/6RBy5imRy3qCy7jzQjQZymFWahfdd+wGNAPKk0bYye4cZtQPVPVRr2u5B7OIrdoGyuMwlnKOOo5dnp9tygZYoNUE5ZwRUBZgbhyyYfGCJlKK83ZdMYbBxhJY23p1/Ry9sZSaM2Dy5Ss7OXglcj7um68lUu7wyc0c5hCfuIG26D1vL1al7wG1/t7uKRMo1Yp8NZoBoE/ROrWKaU0z9RoznyGCN3Zm+jhA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fyBVWgihQPpJFdpahJn6SA7LSBaugD+k2Kc5rCRgJBU0flEV3MGHC9HpcZ75RGuxnTxOjFoYqYC9TA4cRrlaYceFEAXh1GQmcNe9MNqgk1jxWPGLwH7St3Wa5KMFPZMUPm+9goZk0hXPFmLMFpCCR6Pt+9gQWrcCY22ky217O6cKKngJgcvJgBDclfk747cFusviYlX33V2PtBVcPG9qHSH37oZj+/fLJW5x7lWr68CXbikvk4hJoaD7GtqkJ+A9a+416KAkAtFoNrtLU6ErUut3PI4sjkHkhdLK80nT2qazAPVDzGwTrlmqDw9BKXsTEhIElXOkbJjpONSOWFv9Pg==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, "Wei Liu" <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>
  • Delivery-date: Mon, 20 Sep 2021 10:53:48 +0000
  • Ironport-data: A9a23:IGMRiKMYJY9chnjvrR1xkMFynXyQoLVcMsEvi/4bfWQNrUol1TMFn GEbDGjQP6mLYGrzL9kkYN7k/R4G7cWGztAwTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En552Eg7w7RRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozOInNMuk YhJia7zYjYRN5aSlecReRYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iRuIUCjGdg7ixINd3VW ek0exFPVxXBSBgeBQk+N6M4pt790xETdBUH8QnI9MLb+VP70whZwLXrdt3PdbSiR9hRn0uej nLL+SL+GB5yHN2AyxKV/3S0nOjNkCjnHoUIG9WQ9PFwh0aI7ncOExBQXly+ydGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nMk3Rj91j wKNo+GqLg1XuYbLRHGR3LjB+FteJhMpwX8+iT4sFFVeuom48dBr1HojXf44T/Xk1YSd9SXYh mnQ9Xlg3e17Ydsjiv3jlW0rlQ5AsXQgouQd3QzRQmvtxQdwfofNi2eAuAWDsKoowGp0SDC8U Jk4dyq2t7tm4XKlznXlrAAx8FaBva3tDdEkqQQzd6TNDhz0k5JZQWy13N2ZDBwzWvvohBezO BOD0e+vzMYLYRNGkpObk6ruUp93nMAM5PzOV+zOb8omX3SCXFbcp0lTibqr9zm1yiAEyPhnU b/CKJrEJStKWMxPkWvtL89AgOBD+8zL7T6KLXwN50/8iuT2ib/8YeptDWZimchjvfvY/12Ko 4gAXyZIoj0GONDDjuDs2dd7BXgBLGQhBICwrMpSd+WZJRFhFn1nAPjUqY7NsaQ890iMvuuXr Hy7RGFCz1/z2S/OJQmQMygxY7LzR5dv63k8OHV0b1qv3nEiZ6ep7bseKMRrLeV2qrQ7wK4mV eQBduWBHu9LFmbN9QMCYMSvt4dlbhmq216DZnL3fDglcpd8bAXV4du4LBD3/SwDA3Pv58szq rGtzC3BRp8HS1gwBcracqv3nViwoWIciKR5WE6Reotff0Dl8Y5LLS3tj6Bof5FQeEubnjbDj lSYGxYVo+XJsrQZytiRiPDWtZqtHst/AlFeQzvR44GpOHSI5WGk24JBDrqFJGiPSGPu9ay+T uxJ1PWgYuYflVNHvocgQbZmyaUyu4nmq7NAl1k2GXzKaxKgC696I2nA1s5K7/UfyrhcsAqwe 0SO5tgFZunZZJK7SAYcdFg/c+CO9fAIgT2Dv/06LXLz6DJz4LfaA15ZOAOBiXAFIbZ4WG//L TzNZCLCB9SDtycX
  • Ironport-hdrordr: A9a23:C0v8+62OgWQISiqZX5wk4gqjBS5yeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5Wo3SIDUO2VHYVr2KiLGC/9SOIVyaygcw79 YFT0E6MqyOMbEYt7eL3ODbKadZ/DDvysnB7o2yvhQdL3AYV0gj1XYDNu/yKDwGeOAsP+tBKH Pz3Lshm9L2Ek5nEPhTS0N1EtTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJqZmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87ysIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXoHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa1nackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmMG9yV0qp/FWH/ebcG0jaRny9Mww/U42uonZrdUlCvgglLJd1pAZGyHo/I6M0rt gsfJ4Y0o2mdfVmGJ6VMt1xN/dfOla9My4kD1jiVWgPNJt3cE4l+KSHqonc2omRCes1Jd0J6c 38bG8=
  • Ironport-sdr: RAVCgpKBBnsDhrI9+xBzeb7pLzk4gcyjl0IPITZMFit6sK6PPCRlEN6eSxTEhryA0CzZeYlxsQ UC1R+9q+T5NgEMPLDQHNzEvHc0dGY7JU/U+XJkJzRyKqRqsfN/4IDNx+Sl2qkI/YbxTBW+E3B+ iW2qIJIfcKPEyRCGTpiUwWmi6rF5Zx92cr98BwyM37llVf+Aq+3LDXdwbXEyVYAG2hPXOkrCoV 7JuqXMRR45b0jrq7dg3FEOsnWEgATjg5WXltMPGwFRM0iZeR6zUVtP5vms+bed9dYXaUWIGzed CPgUYhvbFJvUZ+vz5ES0Z6a4
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Sep 20, 2021 at 11:22:15AM +0200, Juergen Gross wrote:
> On 17.09.21 17:46, Roger Pau Monne wrote:
> > Exploiting the talloc clean up routines to close the Xen interfaces
> > is cumbersome, specially when atexit can be used to the same effect.
> > 
> > Convert xc and gnttab to use atexit which allows to drop one
> > indirection from the storing variables.
> > 
> > No functional change intended.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> >   tools/xenstore/xenstored_core.h   |  2 +-
> >   tools/xenstore/xenstored_domain.c | 57 +++++++++++++------------------
> >   2 files changed, 25 insertions(+), 34 deletions(-)
> > 
> > diff --git a/tools/xenstore/xenstored_domain.c 
> > b/tools/xenstore/xenstored_domain.c
> > index 47e9107c14..8930303773 100644
> > --- a/tools/xenstore/xenstored_domain.c
> > +++ b/tools/xenstore/xenstored_domain.c
> > @@ -737,35 +725,38 @@ void dom0_init(void)
> >     xenevtchn_notify(xce_handle, dom0->port);
> >   }
> > +void interface_cleanup(void)
> > +{
> > +   if (xc_handle) {
> > +           xc_interface_close(xc_handle);
> > +           xc_handle = NULL;
> > +   }
> > +   if (xgt_handle) {
> > +           xengnttab_close(xgt_handle);
> > +           xgt_handle = NULL;
> > +   }
> 
> Could you please add closing of xce_handle(), too?

Sure, I somehow assumed there was a reason for not closing it related
to live update, but I see that's not the case as you use exec to
launch the new image and atexit handlers are not called in that case.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.